From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QJLJS-0002QL-Fw
	for qemu-devel@nongnu.org; Mon, 09 May 2011 03:55:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QJLJR-0004D9-FL
	for qemu-devel@nongnu.org; Mon, 09 May 2011 03:55:30 -0400
Message-ID: <4DC79DEC.50401@redhat.com>
Date: Mon, 09 May 2011 09:55:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <BANLkTik3hmvH6_tUuEZjR8j0L04PdCk7mw@mail.gmail.com>	<4DC29287.5030106@redhat.com>
	<BANLkTik=gr0K9-_fOTqPQORo37xs2D+9Yg@mail.gmail.com>
In-Reply-To: <BANLkTik=gr0K9-_fOTqPQORo37xs2D+9Yg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response
 patch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Vesely <jano.vesely@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On 05/06/11 10:07, Jan Vesely wrote:
> hi,
> using the modified (single line) patch only works half-way, it sets
> the value in status register (guess that's what that line does :))
> but hw interrupt is not generated.
>
> I tried adding uhci_update_irq and this patch:

> +        s->status |= UHCI_STS_USBERR;
> +        uhci_update_irq(s);

> works.

Good.  Can you create a patch with a changelog entry & signed-off 
please?  I'll go queue it up then.

thanks,
   Gerd