From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] ahci: crash after duplicate bh registration
Date: Mon, 09 May 2011 16:26:43 +0200 [thread overview]
Message-ID: <4DC7F9A3.6070309@redhat.com> (raw)
In-Reply-To: <4DC7F668.2060205@suse.de>
Am 09.05.2011 16:12, schrieb Alexander Graf:
> On 05/08/2011 09:10 PM, Jan Kiszka wrote:
>> Hi Alex,
>>
>> I've seen crashes caused by ahci_check_cmd_bh unregistering a NULL bh.
>> It looks like ahci_dma_set_inactive can a called while there is already
>> a bh hanging around. Patch below cures the issue, but I have no clue if
>> such an invocation order is valid at all.
>
> It's certainly guest triggerable, so yes, let's check here.
>
> Acked-by: Alexander Graf <agraf@suse.de>
Yes, the change makes sense to me. Please resend this as a proper patch,
Jan.
However, I still think Jan's question is valid: Is the AHCI emulation
supposed to run multiple DMA requests at once using the core.c
functions? I'd find it surprising if this actually worked well.
Kevin
next prev parent reply other threads:[~2011-05-09 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 19:10 [Qemu-devel] ahci: crash after duplicate bh registration Jan Kiszka
2011-05-09 14:12 ` Alexander Graf
2011-05-09 14:26 ` Kevin Wolf [this message]
2011-05-09 14:31 ` Alexander Graf
2011-05-09 14:39 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC7F9A3.6070309@redhat.com \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).