From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more
Date: Tue, 10 May 2011 13:39:12 +0200 [thread overview]
Message-ID: <4DC923E0.3080705@redhat.com> (raw)
In-Reply-To: <1304934694-13432-1-git-send-email-armbru@redhat.com>
Am 09.05.2011 11:51, schrieb Markus Armbruster:
> This patch series is about purging the "type hint" from the block
> layer. My previous series cleaned up improper uses it. Remaining
> uses are info block and qdevs ide-drive, scsi-disk.
>
> ide-drive and scsi-disk can either act as disk or as CD drive. They
> use their drive's type hint to decide between disk and CD. This is
> unclean. Disk vs. CD needs to be in qdev, not BlockDriverState,
> because it belongs to the drive's guest part.
>
> Split them into separate devices for disk and CD. Keep the old ones
> for backward compatibility.
>
> Remove the type hint from info block. Its value is unreliable anyway.
> libvirt doesn't use it.
>
> I posted v1 quite some time ago. Since we were working towards a
> release then, we decided to take only the bonus bug fixes (PATCH 1-3),
> and revisit the rest later. Which has turned out to be "somewhat"
> later than anticpiated. Sorry about that.
Thanks, applied to the block branch.
Kevin
next prev parent reply other threads:[~2011-05-10 11:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 9:51 [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more Markus Armbruster
2011-05-09 9:51 ` [Qemu-devel] [PATCH v2 1/5] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd" Markus Armbruster
2011-05-09 11:59 ` Gerd Hoffmann
2011-05-10 8:14 ` Markus Armbruster
2011-05-09 9:51 ` [Qemu-devel] [PATCH v2 2/5] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" Markus Armbruster
2011-05-09 9:51 ` [Qemu-devel] [PATCH v2 3/5] block QMP: Drop query-block member "type" (type= in info block) Markus Armbruster
2011-05-09 9:51 ` [Qemu-devel] [PATCH v2 4/5] blockdev: Store -drive option media in DriveInfo Markus Armbruster
2011-05-09 9:51 ` [Qemu-devel] [PATCH v2 5/5] block: Remove type hint, it's guest matter, doesn't belong here Markus Armbruster
2011-05-09 12:04 ` [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more Gerd Hoffmann
2011-05-10 11:39 ` Kevin Wolf [this message]
2011-05-12 15:05 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2011-05-12 15:05 Markus Armbruster
2011-05-12 15:56 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC923E0.3080705@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).