From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40716)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QJlEz-0002ul-QR
	for qemu-devel@nongnu.org; Tue, 10 May 2011 07:36:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QJlEy-0007XI-MS
	for qemu-devel@nongnu.org; Tue, 10 May 2011 07:36:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QJlEy-0007X8-Di
	for qemu-devel@nongnu.org; Tue, 10 May 2011 07:36:36 -0400
Message-ID: <4DC923E0.3080705@redhat.com>
Date: Tue, 10 May 2011 13:39:12 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1304934694-13432-1-git-send-email-armbru@redhat.com>
In-Reply-To: <1304934694-13432-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs,
	and more
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

Am 09.05.2011 11:51, schrieb Markus Armbruster:
> This patch series is about purging the "type hint" from the block
> layer.  My previous series cleaned up improper uses it.  Remaining
> uses are info block and qdevs ide-drive, scsi-disk.
> 
> ide-drive and scsi-disk can either act as disk or as CD drive.  They
> use their drive's type hint to decide between disk and CD.  This is
> unclean.  Disk vs. CD needs to be in qdev, not BlockDriverState,
> because it belongs to the drive's guest part.
> 
> Split them into separate devices for disk and CD.  Keep the old ones
> for backward compatibility.
> 
> Remove the type hint from info block.  Its value is unreliable anyway.
> libvirt doesn't use it.
> 
> I posted v1 quite some time ago.  Since we were working towards a
> release then, we decided to take only the bonus bug fixes (PATCH 1-3),
> and revisit the rest later.  Which has turned out to be "somewhat"
> later than anticpiated.  Sorry about that.

Thanks, applied to the block branch.

Kevin