From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines
Date: Wed, 11 May 2011 14:04:52 +0200 [thread overview]
Message-ID: <4DCA7B64.7000900@redhat.com> (raw)
In-Reply-To: <1305108925-26048-2-git-send-email-stefanha@linux.vnet.ibm.com>
On 05/11/2011 12:15 PM, Stefan Hajnoczi wrote:
> +#ifdef __i386__
> + asm volatile(
> + "mov %%esp, %%ebx;"
> + "mov %0, %%esp;"
> + "pushl %1;"
> + "call _trampoline;"
> + "mov %%ebx, %%esp;"
> + : : "r" (co->stack + co->stack_size), "r" (co) : "ebx"
> + );
This is incomplete, it should set FS:[4] and FS:[8] to top and bottom of
stack respectively, otherwise exception handling (including SIGSEGV) is
broken. But I think for Windows it's anyway better to use fibers.
Commit this and either I or Stefan Weil will fix it. :)
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2011-05-11 12:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 10:15 [Qemu-devel] [PATCH 0/2] Coroutines for better asynchronous programming Stefan Hajnoczi
2011-05-11 10:15 ` [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines Stefan Hajnoczi
2011-05-11 11:20 ` Kevin Wolf
2011-05-11 12:04 ` Paolo Bonzini [this message]
2011-05-11 12:15 ` Kevin Wolf
2011-05-11 12:51 ` Anthony Liguori
2011-05-11 12:52 ` Paolo Bonzini
2011-05-11 13:05 ` Anthony Liguori
2011-05-11 13:45 ` Paolo Bonzini
2011-05-11 13:51 ` Daniel P. Berrange
2011-05-24 19:37 ` Jamie Lokier
2011-05-24 19:58 ` Stefan Hajnoczi
2011-05-24 20:51 ` Jamie Lokier
2011-05-25 7:09 ` Stefan Hajnoczi
2011-05-25 18:54 ` Richard Henderson
2011-05-24 21:21 ` Anthony Liguori
2011-05-25 7:32 ` Paolo Bonzini
2011-05-24 21:22 ` Anthony Liguori
2011-05-25 11:43 ` Bastien ROUCARIES
2011-05-11 12:36 ` Anthony Liguori
2011-05-11 12:46 ` Paolo Bonzini
2011-05-11 12:54 ` Stefan Hajnoczi
2011-05-11 13:08 ` Kevin Wolf
2011-05-11 19:12 ` Stefan Weil
2011-05-12 7:59 ` Kevin Wolf
2011-05-12 9:51 ` Jan Kiszka
2011-05-12 9:59 ` Stefan Hajnoczi
2011-05-24 19:54 ` Jamie Lokier
2011-05-12 10:02 ` Kevin Wolf
2011-05-11 10:15 ` [Qemu-devel] [PATCH 2/2] coroutine: add check-coroutine automated tests Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA7B64.7000900@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).