qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	Carl Karsten <carl@personnelware.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] adding search to dhcp
Date: Wed, 11 May 2011 22:49:02 +0200	[thread overview]
Message-ID: <4DCAF63E.9060905@web.de> (raw)
In-Reply-To: <BANLkTimB5h91JiTf78Edf9Uj_bLjvydqXQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

On 2011-05-11 18:08, Stefan Hajnoczi wrote:
> On Wed, May 11, 2011 at 4:22 PM, Carl Karsten <carl@personnelware.com> wrote:
>> On Wed, May 11, 2011 at 6:01 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>> Stefan Hajnoczi <stefanha@gmail.com> writes:
>>>
>>>> On Tue, May 10, 2011 at 6:40 PM, Carl Karsten <carl@personnelware.com> wrote:
>>>>> I would expect the syntax to look like this:
>>>>>
>>>>> qemu -hda 1.qcow2 -net nick -net
>>>>> user,hostname=qemu,search=example.com,sales.example.com
>>>>
>>>> Comma escaping is needed but it seems like a reasonable feature to me.
>>>
>>> Comma escaping is ugly:
>>> -net user,hostname=qemu,search=example.com,,sales.example.com
>>>
>>> Could we have multiple search options instead?  Like this:
>>> -net user,hostname=qemu,search=example.com,search=sales.example.com
>>>
>>
>> How about:
>>
>> -net user,hostname=qemu,search="example.com,sales.example.com"
> 
> That does not work the way you'd expect:
> $ echo asdf=asdf,ok="this,is,a,test"
> asdf=asdf,ok=this,is,a,test
> 
> Also, let's not get into the business of matching quotes and passing
> them escaped on the shell.  That's just as ugly as escaping commas and
> more work.
> 
> I think the two options are using QEMU's typical comma escaping ',,'
> or specifying the option multiple times.  I'd go with comma escaping
> for consistency.  I'm not aware of any other option in QEMU that is
> specified multiple times.

-net user,hostfwd=...,hostfwd=...

Let's got for multiple specification, ',,' is just ugly IMHO.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

  reply	other threads:[~2011-05-11 20:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 17:40 [Qemu-devel] adding search to dhcp Carl Karsten
2011-05-11  9:02 ` Stefan Hajnoczi
2011-05-11 11:01   ` Markus Armbruster
2011-05-11 15:22     ` Carl Karsten
2011-05-11 16:08       ` Stefan Hajnoczi
2011-05-11 20:49         ` Jan Kiszka [this message]
2011-05-11 21:08           ` Michael Tokarev
2011-05-12  9:00             ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCAF63E.9060905@web.de \
    --to=jan.kiszka@web.de \
    --cc=armbru@redhat.com \
    --cc=carl@personnelware.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).