From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKSql-0001uc-MW for qemu-devel@nongnu.org; Thu, 12 May 2011 06:10:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKSqk-0003Vn-Ij for qemu-devel@nongnu.org; Thu, 12 May 2011 06:10:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKSqk-0003Vd-8t for qemu-devel@nongnu.org; Thu, 12 May 2011 06:10:30 -0400 Message-ID: <4DCBB2B2.6070307@redhat.com> Date: Thu, 12 May 2011 12:13:06 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1305194086-9832-1-git-send-email-stefanha@linux.vnet.ibm.com> <1305194086-9832-5-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1305194086-9832-5-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] coroutine: pool coroutines to speed up creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel@nongnu.org, Paolo Bonzini , Venkateswararao Jujjuri terAm 12.05.2011 11:54, schrieb Stefan Hajnoczi: > This patch speeds up coroutine creation by reusing freed coroutines. > When a coroutine terminates it is placed in the pool instead of having > its resources freed. The next time a coroutine is created it can be > taken straight from the pool and requires no initialization. > > Performance results on an Intel Core2 Duo T9400 (2.53GHz) for > ./check-coroutine --benchmark-lifecycle 20000000: > > No pooling: 19.5 sec > With pooling: 1.1 sec > > Signed-off-by: Stefan Hajnoczi > --- > check-coroutine.c | 2 ++ > qemu-coroutine-int.h | 2 ++ > qemu-coroutine.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++--- > qemu-coroutine.h | 9 +++++++++ > vl.c | 2 ++ > 5 files changed, 61 insertions(+), 3 deletions(-) > > diff --git a/check-coroutine.c b/check-coroutine.c > index 5a42c49..223c50c 100644 > --- a/check-coroutine.c > +++ b/check-coroutine.c > @@ -218,6 +218,8 @@ int main(int argc, char **argv) > }; > int i; > > + qemu_coroutine_init(); Can we use module_init instead of adding an explicit call to main()? This would prevent forgetting to add it in qemu-img and qemu-io like in this patch. Kevin