From: Avi Kivity <avi@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
qemu-devel@nongnu.org, Brad Hards <bradh@frogmouth.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add documentation for qemu_progres_print()
Date: Thu, 12 May 2011 18:04:44 +0300 [thread overview]
Message-ID: <4DCBF70C.60807@redhat.com> (raw)
In-Reply-To: <m3oc3f3lvs.fsf@blackfin.pond.sub.org>
On 05/06/2011 06:10 PM, Markus Armbruster wrote:
> Here's my try:
>
> /*
> * Report progress.
> * @percent is how much progress we made.
> * If @max is zero, @percent is how much of the job is done.
> * Else, @percent is a progress delta since the last call, as a fraction
> * of @max. I.e. delta is @percent * @max / 100. This is for
> * convenience, it lets you account for @max% of the total work in some
> * function, and still count @percent from 0 to 100.
> */
My personal preference is to use fractions of 1 in the code and only
covert to percentages during actual output.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-05-12 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 9:39 [Qemu-devel] [PATCH qemu-block 0/2] cleanup progress code Jes.Sorensen
2011-05-06 9:39 ` [Qemu-devel] [PATCH 1/2] Add documentation for qemu_progres_print() Jes.Sorensen
2011-05-06 10:40 ` Brad Hards
2011-05-06 11:11 ` Jes Sorensen
2011-05-06 15:10 ` Markus Armbruster
2011-05-09 13:15 ` Jes Sorensen
2011-05-09 13:31 ` Markus Armbruster
2011-05-12 15:04 ` Avi Kivity [this message]
2011-05-06 9:39 ` [Qemu-devel] [PATCH 2/2] qemu-img.c: Remove superfluous parenthesis Jes.Sorensen
2011-05-06 10:46 ` [Qemu-devel] [PATCH qemu-block 0/2] cleanup progress code Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCBF70C.60807@redhat.com \
--to=avi@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=bradh@frogmouth.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).