From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKYHV-0000yH-ET for qemu-devel@nongnu.org; Thu, 12 May 2011 11:58:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKYHO-0005gG-Nh for qemu-devel@nongnu.org; Thu, 12 May 2011 11:58:29 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:42139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKYHO-0005gB-Kq for qemu-devel@nongnu.org; Thu, 12 May 2011 11:58:22 -0400 Received: by yxk8 with SMTP id 8so679561yxk.4 for ; Thu, 12 May 2011 08:58:21 -0700 (PDT) Message-ID: <4DCC039B.5070608@codemonkey.ws> Date: Thu, 12 May 2011 10:58:19 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1305023443-8722-1-git-send-email-kraxel@redhat.com> <201105101624.08253.bradh@frogmouth.net> <4DCBA79B.5040608@redhat.com> <4DCBFBFF.7000203@redhat.com> In-Reply-To: <4DCBFBFF.7000203@redhat.com> Content-Type: multipart/mixed; boundary="------------080008040709060009040208" Subject: Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: amit.shah@redhat.com, Markus Armbruster , Brad Hards , qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------080008040709060009040208 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: > Hi, > >>> What is the status of the qdev documentation patches btw.? >> >> http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html > > What is the problem with the empty strings btw? > > The only way around I can see is having _DOC and _NODOC versions for all > the property macros, but I'd prefer to not have _NODOC macros in the > tree ... Here's an example of what I'm suggesting. I think we should just go with this and add better output as we go. But we need all of the qdev information.. not just a doc string for each property. Regards, Anthony Liguori > > cheers, > Gerd > > --------------080008040709060009040208 Content-Type: text/x-patch; name="0001-qdev-add-centralized-documentation-for-qdev.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-qdev-add-centralized-documentation-for-qdev.patch" >>From 130c817790880c61b79dbccf66f5863c406eb7d4 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Thu, 12 May 2011 10:56:29 -0500 Subject: [PATCH] qdev: add centralized documentation for qdev This is mostly a proof-of-concept. Signed-off-by: Anthony Liguori diff --git a/Makefile b/Makefile index 2b0438c..fddb261 100644 --- a/Makefile +++ b/Makefile @@ -341,5 +341,7 @@ tarbin: $(mandir)/man1/qemu-img.1 \ $(mandir)/man8/qemu-nbd.8 +include $(SRC_PATH)/Makefile.doc + # Include automatically generated dependency files -include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d) diff --git a/Makefile.doc b/Makefile.doc new file mode 100644 index 0000000..f769b23 --- /dev/null +++ b/Makefile.doc @@ -0,0 +1,2 @@ +qdev-doc.html: $(SRC_PATH)/qdev-doc.json + python $(SRC_PATH)/scripts/qdev-doc-to-html.py < $< > $@ diff --git a/qdev-doc.json b/qdev-doc.json new file mode 100644 index 0000000..c24630b --- /dev/null +++ b/qdev-doc.json @@ -0,0 +1,14 @@ +# -*- Mode: Python -*- + +[ { "device": "isa-serial", + "parent": "ISADevice", + "properties": { + "index": { "type": "uint32", + "doc": "A value from 0-3 that describes which IO regions to expose the device on. This sets appropriate values for iobase and irq." }, + "iobase": { "type": "hex32", + "doc": "The base IO address to expose the device on." }, + "irq": { "type": "uint32", + "doc": "The IRQ to use for the device." }, + "chardev": { "type": "chr", + "doc": "The name of a character device to specify." } } } + ] diff --git a/scripts/qdev-doc-to-html.py b/scripts/qdev-doc-to-html.py new file mode 100644 index 0000000..a25fe35 --- /dev/null +++ b/scripts/qdev-doc-to-html.py @@ -0,0 +1,40 @@ +#!/usr/bin/python + +import sys + +data = sys.stdin.read() + +docs = eval(data) + +sys.stdout.write(''' + + +QEMU device documentation + + +''') + +for item in docs: + sys.stdout.write(''' +

%(device)s :: %(parent)s

+ + + + + +''' % item) + for prop in item["properties"]: + sys.stdout.write(''' + + + +''' % (prop, item["properties"][prop]['type'], item["properties"][prop]['doc'])) + + sys.stdout.write(''' +
NameTypeComments
%s%s%s
+''') + +sys.stdout.write(''' + + +''') -- 1.7.4.1 --------------080008040709060009040208--