qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/4] coroutine: introduce coroutines
Date: Fri, 13 May 2011 10:17:58 +0200	[thread overview]
Message-ID: <4DCCE936.7000803@redhat.com> (raw)
In-Reply-To: <BANLkTik3WOcjgbQPAF=ZLaN+J6N-h4=_nQ@mail.gmail.com>

Am 12.05.2011 21:22, schrieb Stefan Hajnoczi:
> On Thu, May 12, 2011 at 7:12 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
>> On Thu, May 12, 2011 at 12:54 PM, Stefan Hajnoczi
>> <stefanha@linux.vnet.ibm.com> wrote:
>>> diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c
>>> new file mode 100644
>>> index 0000000..3b14ebf
>>> --- /dev/null
>>> +++ b/coroutine-ucontext.c
>>> @@ -0,0 +1,73 @@
>>> +/*
>>> + * ucontext coroutine initialization code
>>> + *
>>> + * Copyright (C) 2006  Anthony Liguori <anthony@codemonkey.ws>
>>> + * Copyright (C) 2011  Kevin Wolf <kwolf@redhat.com>
>>> + *
>>> + * This library is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.0 of the License, or (at your option) any later version.
>>> + *
>>> + * This library is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with this library; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
>>
>> Please use the web link version.
> 
> Will update in v3.
> 
>>> + */
>>> +
>>> +/* XXX Is there a nicer way to disable glibc's stack check for longjmp? */
>>
>> What is the problem?
> 
> Kevin?

I don't remember the details of the mechanism, but with _FORTIFY_SOURCE
glibc has some check in longjmp that doesn't like stack switches. If you
uncomment the #undef, you should be able to reproduce the abort().

Kevin

  reply	other threads:[~2011-05-13  8:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12  9:54 [Qemu-devel] [PATCH v2 0/4] Coroutines for better asynchronous programming Stefan Hajnoczi
2011-05-12  9:54 ` [Qemu-devel] [PATCH v2 1/4] coroutine: introduce coroutines Stefan Hajnoczi
2011-05-12 18:12   ` Blue Swirl
2011-05-12 19:22     ` Stefan Hajnoczi
2011-05-13  8:17       ` Kevin Wolf [this message]
2011-05-12  9:54 ` [Qemu-devel] [PATCH v2 2/4] coroutine: add check-coroutine automated tests Stefan Hajnoczi
2011-05-12  9:54 ` [Qemu-devel] [PATCH v2 3/4] coroutine: add check-coroutine --benchmark-lifecycle Stefan Hajnoczi
2011-05-12  9:54 ` [Qemu-devel] [PATCH v2 4/4] coroutine: pool coroutines to speed up creation Stefan Hajnoczi
2011-05-12 10:13   ` Kevin Wolf
2011-05-12 10:22     ` Stefan Hajnoczi
2011-05-12 10:38       ` Kevin Wolf
2011-05-12 11:12         ` Paolo Bonzini
2011-05-12 11:15           ` Stefan Hajnoczi
2011-05-12 11:18             ` Paolo Bonzini
2011-05-12 11:52               ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCCE936.7000803@redhat.com \
    --to=kwolf@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=jvrao@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).