From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLeu1-0006rA-EG for qemu-devel@nongnu.org; Sun, 15 May 2011 13:14:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QLetz-0005oH-8y for qemu-devel@nongnu.org; Sun, 15 May 2011 13:14:49 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:39610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLety-0005nv-Uc for qemu-devel@nongnu.org; Sun, 15 May 2011 13:14:47 -0400 Message-ID: <4DD00A02.1010205@web.de> Date: Sun, 15 May 2011 19:14:42 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20110515163105.GG24932@redhat.com> In-Reply-To: <20110515163105.GG24932@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig45FFB6AEF8F585F4C9ADD141" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] AHCI broken in current git, bisected. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Alexander Graf , Alexey Zaytsev , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig45FFB6AEF8F585F4C9ADD141 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-05-15 18:32, Michael S. Tsirkin wrote: > On Sun, May 15, 2011 at 07:58:23PM +0400, Alexey Zaytsev wrote: >> Hi. >> >> The commit 667bb59d2358daeef179583c944becba3f1f9680 >> Author: Avi Kivity >> Date: Mon Apr 4 18:28:02 2011 +0300 >> >> ich/ahci: convert to pci_register_bar_simple() >> >> Signed-off-by: Avi Kivity >> Signed-off-by: Michael S. Tsirkin >> >> breaks AHCI to the point the disks are not detected by both seabios an= d Linux: >> >> [ 8.582220] ata1: PATA max MWDMA2 cmd 0x1f0 ctl 0x3f6 bmdma 0xc000 = irq 14 >> [ 8.582646] ata2: PATA max MWDMA2 cmd 0x170 ctl 0x376 bmdma 0xc008 = irq 15 >> [ 8.603979] ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 10 >> [ 8.605151] ahci 0000:00:04.0: PCI INT A -> Link[LNKD] -> GSI 10 >> (level, high) -> IRQ 10 >> [ 9.608243] ahci 0000:00:04.0: controller reset failed (0xf000ff53)= >> [ 9.609948] ahci 0000:00:04.0: PCI INT A disabled >> [ 9.610267] ahci: probe of 0000:00:04.0 failed with error -5 >=20 > Sure enough, >=20 > /* XXX BAR size should be 1k, but that breaks, so bump it to 4k for= now */ > pci_register_bar_simple(&d->card, 5, 0x1000, 0, d->ahci.mem); > msi_init(dev, 0x50, 1, true, false); > ahci_init(&d->ahci, &dev->qdev, 6); >=20 > where ahci_init initializes d->ahci.mem. >=20 > Coul;d you try out the following please > (untested, a bit busy now)? See also http://permalink.gmane.org/gmane.comp.emulators.qemu/101978 Jan --------------enig45FFB6AEF8F585F4C9ADD141 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3QCgUACgkQitSsb3rl5xRbEgCg5PSYEbTGGzk4CX+OxVl920vf 1vwAn3DZ2dBGR1EtwjU8zcXMUqp5TcWJ =AV5B -----END PGP SIGNATURE----- --------------enig45FFB6AEF8F585F4C9ADD141--