From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMEZl-0007Qp-U5 for qemu-devel@nongnu.org; Tue, 17 May 2011 03:20:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMEZk-0006wQ-Ug for qemu-devel@nongnu.org; Tue, 17 May 2011 03:20:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMEZk-0006wK-KY for qemu-devel@nongnu.org; Tue, 17 May 2011 03:20:16 -0400 Message-ID: <4DD221AB.7070009@redhat.com> Date: Tue, 17 May 2011 09:20:11 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1305575782-31766-1-git-send-email-kraxel@redhat.com> <1305575782-31766-19-git-send-email-kraxel@redhat.com> <4DD1E1DD.3060605@cisco.com> In-Reply-To: <4DD1E1DD.3060605@cisco.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Ahern Cc: qemu-devel@nongnu.org > On 05/16/11 13:56, Gerd Hoffmann wrote: >> This patch finally merges the EHCI host adapter aka USB 2.0 support. >> >> Based on git://git.kiszka.org/qemu.git ehci >> >> Changes: >> - Adapt to recent changes in the usb subsystem. >> - Don't create device automagically, use -device instead. >> - Add quickstart text file, see docs/usb2.txt. >> - A bunch of codestyle fixups. >> - Add authors+contributers list. >> - Zap EHCI_NOMICROFRAMES, qemu can't handle a 8 kHz >> wakeup rate anyway. >> - A few bug fixes. >> >> Signed-off-by: Gerd Hoffmann > > As someone who spent a significant amount of time working on the EHCI > code last year I am absolutely not ok with this. The entire contribution > history for EHCI lost - and for no reason. There is a reason. I've tried to keep the history, but it was a big mess with conflicts and build errors due to ehci being out-of-tree for a loooooong time. > The inclusion of EHCI into > qemu can be done in such a way as to maintain the history. Prove it. Give me a git tree with ehci history I can use as replacement for patch 18 and I'll pull it in. cheers, Gerd