From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40957)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1QMGRN-0003Mq-KE
	for qemu-devel@nongnu.org; Tue, 17 May 2011 05:19:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1QMGRM-00034J-O5
	for qemu-devel@nongnu.org; Tue, 17 May 2011 05:19:45 -0400
Received: from e28smtp04.in.ibm.com ([122.248.162.4]:42029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1QMGRM-00033H-4v
	for qemu-devel@nongnu.org; Tue, 17 May 2011 05:19:44 -0400
Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60])
	by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id p4H9JbTD018152
	for <qemu-devel@nongnu.org>; Tue, 17 May 2011 14:49:37 +0530
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p4H9JaDk3440892
	for <qemu-devel@nongnu.org>; Tue, 17 May 2011 14:49:37 +0530
Received: from d28av05.in.ibm.com (loopback [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p4H9Ja9e030306
	for <qemu-devel@nongnu.org>; Tue, 17 May 2011 19:19:36 +1000
Message-ID: <4DD23944.6030608@in.ibm.com>
Date: Tue, 17 May 2011 14:30:52 +0530
From: supriya kannery <supriyak@in.ibm.com>
MIME-Version: 1.0
References: <20110516181023.7142.33402.sendpatchset@skannery>
	<20110516181037.7142.76146.sendpatchset@skannery>
	<4DD23454.7070705@redhat.com>
In-Reply-To: <4DD23454.7070705@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC Patch 1/3]Qemu: Enhance "info block" to
 display cache setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Supriya Kannery <supriyak@linux.vnet.ibm.com>, Prerna Saxena <prerna@linux.vnet.ibm.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

Kevin Wolf wrote:
> Am 16.05.2011 20:10, schrieb Supriya Kannery:
>   
>> Enhance "info block" to display cache setting
>>
>> Example:
>> (qemu) info block
>> ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 
>> encrypted=0
>>
>> Enhanced to include "cache" setting:
>> (qemu) info block
>> ide0-hd0: type=hd removable=0 cache=none file=../rhel6-32.qcow2 ro=0 
>> drv=qcow2 encrypted=0
>>
>>     

>>  
>>          bs_obj = qobject_from_jsonf("{ 'device': %s, 'type': %s, "
>> -                                    "'removable': %i, 'locked': %i }",
>> +                                    "'removable': %i, 'locked': %i, "
>> +                                    "'open_flags': %d }",
>>                                      bs->device_name, type, bs->removable,
>> -                                    bs->locked);
>> +                                    bs->locked, bs->open_flags);
>>  
>>          if (bs->drv) {
>>              QObject *obj;
>>     
>
> bs->open_flags is a purely internal thing and its meaning is not
> guaranteed to be stable. Exposing it to the user is wrong.
>
>   
ok. Pls suggest what could a better approach to expose the cache setting.
> Kevin
>
>