From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMLOO-0002Mk-Ua for qemu-devel@nongnu.org; Tue, 17 May 2011 10:37:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMLOO-0000tF-5H for qemu-devel@nongnu.org; Tue, 17 May 2011 10:37:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMLON-0000t1-OC for qemu-devel@nongnu.org; Tue, 17 May 2011 10:37:00 -0400 Message-ID: <4DD28807.7040104@redhat.com> Date: Tue, 17 May 2011 16:36:55 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1305575782-31766-1-git-send-email-kraxel@redhat.com> <1305575782-31766-19-git-send-email-kraxel@redhat.com> <4DD1E1DD.3060605@cisco.com> <4DD221AB.7070009@redhat.com> <4DD26D45.3070309@cisco.com> <4DD27C4B.90907@redhat.com> <4DD28406.6000104@cisco.com> In-Reply-To: <4DD28406.6000104@cisco.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Ahern Cc: qemu-devel@nongnu.org Hi, > Right, you did not even try to work with Jan's tree. There is no reason > the EHCI code could not have been brought in to qemu that way. The usual way to review & merge code is to send a patch series against recent master to qemu-devel, optionally with a git tree to pull from. So I tried to do that for ehci by merging & rebasing Jan's tree. Didn't work out as described multiple times. Using Jan's tree as-is isn't an option IMHO. The patches didn't got a serious review @ qemu-devel. IIRC the tree was more meant as "collect bits here so they doesn't get lost" not as "this stuff is ready for merge". cheers, Gerd