From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QMazd-0004wn-EV
	for qemu-devel@nongnu.org; Wed, 18 May 2011 03:16:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QMazc-0002iR-Cx
	for qemu-devel@nongnu.org; Wed, 18 May 2011 03:16:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QMazc-0002iJ-67
	for qemu-devel@nongnu.org; Wed, 18 May 2011 03:16:28 -0400
Message-ID: <4DD37245.20009@redhat.com>
Date: Wed, 18 May 2011 09:16:21 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20110516102529.GF27965@playa.redhat.com>
	<1305633825-6171-1-git-send-email-alevy@redhat.com>
	<20110517123209.GF7083@playa.tlv.redhat.com>
	<20110518034240.GL7083@playa.tlv.redhat.com>
In-Reply-To: <20110518034240.GL7083@playa.tlv.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 05/18/2011 05:42 AM, Alon Levy wrote:
>>> ---
>>>   Makefile           |   20 +++++++++++++++++++-
>>>   Makefile.objs      |    3 +++
>>>   configure          |   12 +++++++++++-
>>>   libcacard/Makefile |   32 ++++++++++++++++++++++++++++----
>>>   rules.mak          |    3 +++
>>>   5 files changed, 64 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 2b0438c..c71026c 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -119,6 +119,23 @@ version.o: $(SRC_PATH)/version.rc config-host.mak
>>>
>>>   version-obj-$(CONFIG_WIN32) += version.o
>>>   ######################################################################
>>> +# Support building shared library libcacard
>>> +
>>> +.PHONY: libcacard.la install-libcacard
>>> +ifeq ($(LIBTOOL),)
>>> +libcacard.la:
>>> +	@echo libtool is missing, please install and rerun configure
>>> +
>>> +install-libcacard:
>>> +	@echo libtool is missing, please install and rerun configure
>>> +else
>>> +libcacard.la: $(GENERATED_HEADERS) $(oslib-obj-y) qemu-malloc.o qemu-timer-common.o $(addsuffix .lo, $(basename $(trace-obj-y)))
>>> +	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libcacard V="$(V)" TARGET_DIR="$*/" libcacard.la,)
>>> +
>>> +install-libcacard: libcacard.la
>>> +	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libcacard V="$(V)" TARGET_DIR="$*/" install-libcacard,)
>>> +endif

If you instead make the .lo rules display the error message (and add "; 
exit 1" after the echo), you can remove this ifeq.  I'll let you decide 
whether to do this or not.

Otherwise looks good, thanks!

Paolo