qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: lcapitulino@redhat.com, hch@lst.de, qemu-devel@nongnu.org,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM
Date: Wed, 18 May 2011 17:51:59 +0200	[thread overview]
Message-ID: <4DD3EB1F.9060104@redhat.com> (raw)
In-Reply-To: <1305551097-11387-4-git-send-email-armbru@redhat.com>

Am 16.05.2011 15:04, schrieb Markus Armbruster:
> ide-hd does *not* suppress the default CD-ROM, unlike legacy
> ide-drive.
> 
> scsi-cd *does* suppress it, unlike legacy scsi-disk.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  vl.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index bffba69..e271c0b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -279,7 +279,9 @@ static struct {
>      { .driver = "isa-serial",           .flag = &default_serial    },
>      { .driver = "isa-parallel",         .flag = &default_parallel  },
>      { .driver = "isa-fdc",              .flag = &default_floppy    },
> +    { .driver = "ide-cd",               .flag = &default_cdrom     },
>      { .driver = "ide-drive",            .flag = &default_cdrom     },
> +    { .driver = "scsi-cd",              .flag = &default_cdrom     },
>      { .driver = "virtio-serial-pci",    .flag = &default_virtcon   },
>      { .driver = "virtio-serial-s390",   .flag = &default_virtcon   },
>      { .driver = "virtio-serial",        .flag = &default_virtcon   },

Wow, I wasn't even aware that we have such magic in relatively new code
like -device. And that it's only effective for -device, but not -drive.
And to be honest, I really never wanted to know...

Anyway, you can't create an ide-hd on secondary master now because there
is the default CD-ROM already:

qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: IDE
unit 0 is in use
qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: Device
'ide-hd' could not be initialized

Kevin

  reply	other threads:[~2011-05-18 15:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 13:04 [Qemu-devel] [PATCH v4 0/6] Split ide-drive and scsi-disk qdevs, and more Markus Armbruster
2011-05-16 13:04 ` [Qemu-devel] [PATCH v4 1/6] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd" Markus Armbruster
2011-05-16 13:04 ` [Qemu-devel] [PATCH v4 2/6] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" Markus Armbruster
2011-05-16 13:04 ` [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM Markus Armbruster
2011-05-18 15:51   ` Kevin Wolf [this message]
2011-05-18 16:30     ` Markus Armbruster
2011-05-18 16:31   ` [Qemu-devel] [PATCH v5 3/6] defaults: ide-cd, ide-hd " Markus Armbruster
2011-05-16 13:04 ` [Qemu-devel] [PATCH v4 4/6] block QMP: Deprecate query-block's "type", drop info block's "type=" Markus Armbruster
2011-05-18 12:44   ` Kevin Wolf
2011-05-18 13:08     ` Luiz Capitulino
2011-05-16 13:04 ` [Qemu-devel] [PATCH v4 5/6] blockdev: Store -drive option media in DriveInfo Markus Armbruster
2011-05-16 13:04 ` [Qemu-devel] [PATCH v4 6/6] block: Remove type hint, it's guest matter, doesn't belong here Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD3EB1F.9060104@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=hch@lst.de \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).