From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMizu-0001nM-DM for qemu-devel@nongnu.org; Wed, 18 May 2011 11:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMizt-0002SN-E4 for qemu-devel@nongnu.org; Wed, 18 May 2011 11:49:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMizt-0002SJ-58 for qemu-devel@nongnu.org; Wed, 18 May 2011 11:49:17 -0400 Message-ID: <4DD3EB1F.9060104@redhat.com> Date: Wed, 18 May 2011 17:51:59 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1305551097-11387-1-git-send-email-armbru@redhat.com> <1305551097-11387-4-git-send-email-armbru@redhat.com> In-Reply-To: <1305551097-11387-4-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: lcapitulino@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com Am 16.05.2011 15:04, schrieb Markus Armbruster: > ide-hd does *not* suppress the default CD-ROM, unlike legacy > ide-drive. > > scsi-cd *does* suppress it, unlike legacy scsi-disk. > > Signed-off-by: Markus Armbruster > --- > vl.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/vl.c b/vl.c > index bffba69..e271c0b 100644 > --- a/vl.c > +++ b/vl.c > @@ -279,7 +279,9 @@ static struct { > { .driver = "isa-serial", .flag = &default_serial }, > { .driver = "isa-parallel", .flag = &default_parallel }, > { .driver = "isa-fdc", .flag = &default_floppy }, > + { .driver = "ide-cd", .flag = &default_cdrom }, > { .driver = "ide-drive", .flag = &default_cdrom }, > + { .driver = "scsi-cd", .flag = &default_cdrom }, > { .driver = "virtio-serial-pci", .flag = &default_virtcon }, > { .driver = "virtio-serial-s390", .flag = &default_virtcon }, > { .driver = "virtio-serial", .flag = &default_virtcon }, Wow, I wasn't even aware that we have such magic in relatively new code like -device. And that it's only effective for -device, but not -drive. And to be honest, I really never wanted to know... Anyway, you can't create an ide-hd on secondary master now because there is the default CD-ROM already: qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: IDE unit 0 is in use qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: Device 'ide-hd' could not be initialized Kevin