From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1QMlVQ-0003CD-Sx
	for qemu-devel@nongnu.org; Wed, 18 May 2011 14:30:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1QMlVQ-0002W8-1s
	for qemu-devel@nongnu.org; Wed, 18 May 2011 14:30:00 -0400
Received: from e34.co.us.ibm.com ([32.97.110.152]:43564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jvrao@linux.vnet.ibm.com>) id 1QMlVP-0002Vs-SY
	for qemu-devel@nongnu.org; Wed, 18 May 2011 14:30:00 -0400
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4IIHOD9009877
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 12:17:24 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p4IIV08g024246
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 12:31:02 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p4ICRrwT021672
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 06:27:53 -0600
Received: from oc6675851006.ibm.com (dyn9047029068.beaverton.ibm.com
	[9.47.29.68])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id
	p4ICRqpx021631
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 06:27:53 -0600
Message-ID: <4DD40FC3.2060207@linux.vnet.ibm.com>
Date: Wed, 18 May 2011 11:28:19 -0700
From: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1305661431-21289-1-git-send-email-jvrao@linux.vnet.ibm.com>
	<1305661431-21289-6-git-send-email-jvrao@linux.vnet.ibm.com>
	<BANLkTinG+vgfRX1FJuwKbP3ycAyYE9rM3Q@mail.gmail.com>
In-Reply-To: <BANLkTinG+vgfRX1FJuwKbP3ycAyYE9rM3Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into
	v9fs_do_readlink
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 05/18/2011 02:31 AM, Stefan Hajnoczi wrote:
> On Tue, May 17, 2011 at 8:43 PM, Venkateswararao Jujjuri (JV)
> <jvrao@linux.vnet.ibm.com>  wrote:
>> Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
>> ---
>>   hw/9pfs/virtio-9p.c |   32 ++++++++++++++++----------------
>>   1 files changed, 16 insertions(+), 16 deletions(-)
> Please see my comment from v1:
> "The len argument is redundant and not used by any callers, please just
> return -errno and drop the len argument.  Callers rely on buf->size
> instead."
We took care of this while introducing coroutines in patch 6.
06/25 will modify functions for the new int v9fs_co_readlink(V9fsState 
*s, V9fsString *path, V9fsString *buf)

Thanks,
JV
> Stefan
>