From: Paolo Bonzini <pbonzini@redhat.com>
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 4/5] exec.c: refactor cpu_physical_memory_map
Date: Wed, 18 May 2011 23:56:56 +0200 [thread overview]
Message-ID: <4DD440A8.60300@redhat.com> (raw)
In-Reply-To: <1305741151-4793-4-git-send-email-stefano.stabellini@eu.citrix.com>
On 05/18/2011 07:52 PM, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
> Introduce qemu_ram_ptr_length that takes an address and a size as
> parameters rather than just an address.
>
> Refactor cpu_physical_memory_map so that we call qemu_ram_ptr_length only
> once rather than calling qemu_get_ram_ptr one time per page.
> This is not only more efficient but also tries to simplify the logic of
> the function.
> Currently we are relying on the fact that all the pages are mapped
> contiguously in qemu's address space: we have a check to make sure that
> the virtual address returned by qemu_get_ram_ptr from the second call on
> is consecutive. Now we are making this more explicit replacing all the
> calls to qemu_get_ram_ptr with a single call to qemu_ram_ptr_length
> passing a size argument.
Would the interface at
http://permalink.gmane.org/gmane.comp.emulators.qemu/101475 work for you
alternatively?
Paolo
next prev parent reply other threads:[~2011-05-18 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 17:51 [Qemu-devel] [PATCH 0 of 5] xen mapcache fixes and improvements Stefano Stabellini
2011-05-18 17:52 ` [Qemu-devel] [PATCH 1/5] xen: fix qemu_map_cache with size != MCACHE_BUCKET_SIZE stefano.stabellini
2011-05-18 17:52 ` [Qemu-devel] [PATCH 2/5] xen: remove qemu_map_cache_unlock stefano.stabellini
2011-05-18 17:52 ` [Qemu-devel] [PATCH 3/5] xen: remove xen_map_block and xen_unmap_block stefano.stabellini
2011-05-18 17:52 ` [Qemu-devel] [PATCH 4/5] exec.c: refactor cpu_physical_memory_map stefano.stabellini
2011-05-18 21:56 ` Paolo Bonzini [this message]
2011-05-19 17:21 ` Stefano Stabellini
2011-05-18 17:52 ` [Qemu-devel] [PATCH 5/5] xen: mapcache performance improvements stefano.stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD440A8.60300@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).