qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "René Rebe" <rene@exactcode.de>, "Jan Kiszka" <jan.kiszka@web.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"Alexey Zaytsev" <alexey.zaytsev@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits
Date: Thu, 19 May 2011 12:09:35 +0200	[thread overview]
Message-ID: <4DD4EC5F.7090402@redhat.com> (raw)
In-Reply-To: <1305799029-19093-1-git-send-email-agraf@suse.de>

Am 19.05.2011 11:57, schrieb Alexander Graf:
> AHCI provides two ways of reading/writing data:
> 
>  1) NCQ
>  2) ATA commands with the LBA in the command FIS
> 
> In the second code path, we didn't handle any LBAs that were bigger than
> 16 bits, so whenever a guest that used high LBA numbers wanted to access
> data, the LBA got truncated down to 16 bits, giving the guest garbage.
> 
> This patch adds support for LBAs higher than 16 bits. I've tested that it
> works just fine with SeaBIOS and Linux guests. This patch also unbreaks
> the often reported grub errors people have seen with AHCI.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> 
> ---
> 
> v1 -> v2:
> 
>   - document fis bytes

Thanks, applied to the block branch.

Kevin

  reply	other threads:[~2011-05-19 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19  9:57 [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits Alexander Graf
2011-05-19 10:09 ` Kevin Wolf [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-24 22:46 Alexander Graf
2011-05-24 22:58 ` Alexander Graf
2011-05-18 12:48 Alexander Graf
2011-05-18 19:16 ` Jan Kiszka
2011-05-18 19:38   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD4EC5F.7090402@redhat.com \
    --to=kwolf@redhat.com \
    --cc=agraf@suse.de \
    --cc=alexey.zaytsev@gmail.com \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rene@exactcode.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).