From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN08E-0000OU-Ed for qemu-devel@nongnu.org; Thu, 19 May 2011 06:07:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QN08D-0005N6-8j for qemu-devel@nongnu.org; Thu, 19 May 2011 06:07:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN08D-0005Mt-1b for qemu-devel@nongnu.org; Thu, 19 May 2011 06:07:01 -0400 Message-ID: <4DD4EC5F.7090402@redhat.com> Date: Thu, 19 May 2011 12:09:35 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1305799029-19093-1-git-send-email-agraf@suse.de> In-Reply-To: <1305799029-19093-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: =?ISO-8859-15?Q?Ren=E9_Rebe?= , Jan Kiszka , "qemu-devel@nongnu.org Developers" , Alexey Zaytsev Am 19.05.2011 11:57, schrieb Alexander Graf: > AHCI provides two ways of reading/writing data: > > 1) NCQ > 2) ATA commands with the LBA in the command FIS > > In the second code path, we didn't handle any LBAs that were bigger than > 16 bits, so whenever a guest that used high LBA numbers wanted to access > data, the LBA got truncated down to 16 bits, giving the guest garbage. > > This patch adds support for LBAs higher than 16 bits. I've tested that it > works just fine with SeaBIOS and Linux guests. This patch also unbreaks > the often reported grub errors people have seen with AHCI. > > Signed-off-by: Alexander Graf > > --- > > v1 -> v2: > > - document fis bytes Thanks, applied to the block branch. Kevin