From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN2oi-0004Yj-MG for qemu-devel@nongnu.org; Thu, 19 May 2011 08:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QN2oh-0000IO-M8 for qemu-devel@nongnu.org; Thu, 19 May 2011 08:59:04 -0400 Received: from goliath.siemens.de ([192.35.17.28]:33188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN2oh-0000Hw-Ch for qemu-devel@nongnu.org; Thu, 19 May 2011 08:59:03 -0400 Message-ID: <4DD51413.1050202@siemens.com> Date: Thu, 19 May 2011 14:58:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4DD3D236.90708@siemens.com> <4DD3D95E.2060105@redhat.com> <4DD3E1B3.3020405@siemens.com> <4DD3E47F.9060104@redhat.com> <4DD3E782.8090208@siemens.com> <4DD3E8D6.6090807@redhat.com> <20110519090851.GD28399@redhat.com> <4DD4DE8E.8030402@redhat.com> <20110519091404.GE28399@redhat.com> <4DD5029D.6000700@redhat.com> <20110519115405.GG28399@redhat.com> <4DD505C4.6010604@redhat.com> <4DD50B17.7000205@siemens.com> <4DD511FB.3080901@redhat.com> In-Reply-To: <4DD511FB.3080901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel , Gleb Natapov On 2011-05-19 14:50, Avi Kivity wrote: > On 05/19/2011 03:20 PM, Jan Kiszka wrote: >>> >>> An example is ne2000-isa and ne2000-pci. There's no getting around some >>> glue logic, but I think this API minimizes it (you can declare >>> everything about your memory region in common code, the only thing that >>> is different is registration). >> >> If devices register against the corresponding qbus (I expect we'll have >> multiple ones in the future), not even that need to be different. > > Eventually we may make the memory API a sub-API of qdev. I don't want > to start with that however, the change is large enough already. Touching all devices again at that point to change the way they register regions may not be the best approach. I would try to consolidate the refactoring work that affects the majority of device models. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux