From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QN4La-000359-En
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:37:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QN4LZ-0000sJ-KX
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:37:06 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:34511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QN4LZ-0000sF-Hy
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:37:05 -0400
Received: by yxk8 with SMTP id 8so1084262yxk.4
	for <qemu-devel@nongnu.org>; Thu, 19 May 2011 07:37:05 -0700 (PDT)
Message-ID: <4DD52B0E.2080604@codemonkey.ws>
Date: Thu, 19 May 2011 09:37:02 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4DD3D236.90708@siemens.com>	<4DD3D95E.2060105@redhat.com>	<4DD3E1B3.3020405@siemens.com>	<4DD3E47F.9060104@redhat.com>	<4DD3E782.8090208@siemens.com>	<4DD3E8D6.6090807@redhat.com>	<20110519090851.GD28399@redhat.com>	<4DD4DE8E.8030402@redhat.com>	<20110519091404.GE28399@redhat.com>	<4DD5029D.6000700@redhat.com>	<20110519115405.GG28399@redhat.com>	<4DD505C4.6010604@redhat.com>	<4DD50B17.7000205@siemens.com>	<4DD511FB.3080901@redhat.com>	<4DD51413.1050202@siemens.com>	<4DD51468.7050509@redhat.com>	<4DD51531.7000701@siemens.com>	<4DD515F9.1020902@redhat.com>	<4DD51A82.7060205@siemens.com>	<4DD51B64.8000306@redhat.com>	<4DD51FDA.3010107@codemonkey.ws>	<4DD520ED.8010606@redhat.com>	<4DD5260A.1080309@codemonkey.ws>
	<4DD5272F.5000003@siemens.com>	<4DD52848.6030102@codemonkey.ws>
	<4DD52910.4080106@siemens.com>
In-Reply-To: <4DD52910.4080106@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, Gleb Natapov <gleb@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 05/19/2011 09:28 AM, Jan Kiszka wrote:
> On 2011-05-19 16:25, Anthony Liguori wrote:
>> On 05/19/2011 09:20 AM, Jan Kiszka wrote:
>>> On 2011-05-19 16:15, Anthony Liguori wrote:
>>> Priorities would be local, so the normal tree would look like this:
>>>
>>>    - CPU:0
>>>      - i440fx:0
>>>        - PIIX3:0
>>>          - DeviceA
>>>        - PCI-DeviceB:0
>>>
>>> If the i440fx would like to map something different over DeviceA (or
>>> parts of it), it would create a region of prio 1 or higher.
>>
>> If it's local, then you need a local dispatch table, no?
>
> Not working for the coalescing reason pointed out before. It's also more
> handy to rely on the core to do the proper dispatching then write your
> own logic over and over again. The core has to deal with overlapping anyway.

So....  do you do:

isa_register_region(ISABus *bus, MemoryRegion *mr, int priority)
{
     chipset_register_region(bus->chipset, mr, priority + 1);
}

I don't really understand how you can fold everything into one table and 
not allow devices to override their parents using priorities.

Regards,

Anthony Liguori

>
> Jan
>