From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN8t5-0004nz-Cz for qemu-devel@nongnu.org; Thu, 19 May 2011 15:28:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QN8t4-0005Uo-Bc for qemu-devel@nongnu.org; Thu, 19 May 2011 15:27:59 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:40467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN8t4-0005Uc-0i for qemu-devel@nongnu.org; Thu, 19 May 2011 15:27:58 -0400 Message-ID: <4DD56F3B.70205@web.de> Date: Thu, 19 May 2011 21:27:55 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1305814352-15044-1-git-send-email-avi@redhat.com> <1305814352-15044-2-git-send-email-avi@redhat.com> In-Reply-To: <1305814352-15044-2-git-send-email-avi@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3B28C9DA454DDA8E0DAB7CD8" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3B28C9DA454DDA8E0DAB7CD8 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-05-19 16:12, Avi Kivity wrote: > +/* Sets an offset to be added to MemoryRegionOps callbacks. */ > +void memory_region_set_offset(MemoryRegion *mr, target_phys_addr_t off= set); Please mark this as a legacy helper, ideally to be removed after the complete conversion to this API. During that phase we should try to identify those devices which still depend on offset=3D0 and maybe directl= y fix them. > +/* Turn loggging on or off for specified client (display, migration) *= / > +void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client= ); > +/* Enable memory coalescing for the region. MMIO ->write callbacks ma= y be > + * delayed until a non-coalesced MMIO is issued. > + */ > +void memory_region_set_coalescing(MemoryRegion *mr); > +/* Enable memory coalescing for a sub-range of the region. MMIO ->wri= te > + * callbacks may be delayed until a non-coalesced MMIO is issued. > + */ > +void memory_region_add_coalescing(MemoryRegion *mr, > + target_phys_addr_t offset, > + target_phys_addr_t size); Will this be such a common use case that requesting the user to split up the region and then use set_coalescing will generate too much boiler plate code? > +/* Disable MMIO coalescing for the region. */ > +void memory_region_clear_coalescing(MemoryRegion *mr); And what about clearing coalescing for sub-ranges? Maybe skip add_coalescing for the first run and see how far we get. Jan --------------enig3B28C9DA454DDA8E0DAB7CD8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3VbzsACgkQitSsb3rl5xSdrwCgmH3nCjYwSK51Ydl7dB5nygJB +7UAnRfa3Q7VnFF/33qaK7iSqWEYSuxK =t7jY -----END PGP SIGNATURE----- --------------enig3B28C9DA454DDA8E0DAB7CD8--