From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42940)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNAZe-0004op-M0
	for qemu-devel@nongnu.org; Thu, 19 May 2011 17:16:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNAZd-0004Pa-TI
	for qemu-devel@nongnu.org; Thu, 19 May 2011 17:16:02 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:40054)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNAZd-0004PW-Pb
	for qemu-devel@nongnu.org; Thu, 19 May 2011 17:16:01 -0400
Received: by yxk8 with SMTP id 8so1263716yxk.4
	for <qemu-devel@nongnu.org>; Thu, 19 May 2011 14:16:01 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DD5888C.2070205@twiddle.net>
Date: Thu, 19 May 2011 14:15:56 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1305671572-5899-1-git-send-email-jcmvbkbc@gmail.com>
	<1305671572-5899-12-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1305671572-5899-12-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/26] target-xtensa: implement shifts (ST1
 and	RST1 groups)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

On 05/17/2011 03:32 PM, Max Filippov wrote:
> +uint32_t HELPER(nsa)(uint32_t v)
> +{
> +    if (v & 0x80000000) {
> +        v = ~v;
> +    }
> +    return v ? 31 : clz32(v) - 1;

Condition is reversed here.


r~