qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Supriya Kannery <supriyak@in.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor
Date: Fri, 20 May 2011 11:11:30 +0530	[thread overview]
Message-ID: <4DD5FF0A.9070100@in.ibm.com> (raw)
In-Reply-To: <20110517154126.GA27700@lst.de>

On 05/17/2011 09:11 PM, Christoph Hellwig wrote:
> On Mon, May 16, 2011 at 04:10:21PM -0500, Anthony Liguori wrote:
>> To further clarify:
>>
>> Today cache=none|writethrough|writeback does two things.  It:
>>
>> 1) Changes the WCE flag that's visible to the guest
>>
>> 2) Determines whether the host page cache is used for doing guest I/O
>>
>> As Christoph is very correct in pointing out, we cannot change (1) at run
>> time because this is guest visible.  You will break a guest if you do this.
>>
>> But it's still desirable to be able to change (2) at run time.  Before we
>> can do this properly though, we need to separate out the logic for setting
>> (1) vs. (2).
>>
>> And ideally, we would allow (1) to be changed by the guest itself at run
>> time which allows for full dynamic control.  This is what he's referring to
>> below.
>
> Exactly.  Setting/clearing the BDRV_O_NO_FLUSH also seems useful, maybe
> in addition to also allowing an equivalent for the writethrough modes.
>

Posted second version of the patchset (RFC) which supports only 
hostcache setting/clearing from qemu monitor.
http://www.mail-archive.com/qemu-devel@nongnu.org/msg64658.html
Please comment.

  reply	other threads:[~2011-05-20  5:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 18:10 [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor Supriya Kannery
2011-05-16 18:10 ` [Qemu-devel] [RFC Patch 1/3]Qemu: Enhance "info block" to display cache setting Supriya Kannery
2011-05-17  8:39   ` Kevin Wolf
2011-05-17  9:00     ` supriya kannery
2011-05-16 18:10 ` [Qemu-devel] [RFC Patch 2/3]Qemu: New error classes for file reopen and device insertion Supriya Kannery
2011-05-16 18:11 ` [Qemu-devel] [RFC Patch 3/3]Qemu: Add command "cache_set" for dynamic cache change Supriya Kannery
2011-05-16 20:23 ` [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor Christoph Hellwig
2011-05-16 21:10   ` Anthony Liguori
2011-05-17  9:27     ` supriya kannery
2011-05-17 15:41     ` Christoph Hellwig
2011-05-20  5:41       ` Supriya Kannery [this message]
2011-05-17  9:18   ` supriya kannery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD5FF0A.9070100@in.ibm.com \
    --to=supriyak@in.ibm.com \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=prerna@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).