From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QNOWA-00014o-1T
	for qemu-devel@nongnu.org; Fri, 20 May 2011 08:09:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QNOW8-0006Ri-Qz
	for qemu-devel@nongnu.org; Fri, 20 May 2011 08:09:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36074)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QNOW8-0006Rb-K8
	for qemu-devel@nongnu.org; Fri, 20 May 2011 08:09:20 -0400
Message-ID: <4DD659E9.7020501@redhat.com>
Date: Fri, 20 May 2011 14:09:13 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1305889177-10490-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1305889177-10490-2-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1305889177-10490-2-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 1/3] coroutine: introduce coroutines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 05/20/2011 12:59 PM, Stefan Hajnoczi wrote:
> This coroutines implementation is based on the gtk-vnc implementation
> written by Anthony Liguori<anthony@codemonkey.ws>  but it has been
> significantly rewritten by Kevin Wolf<kwolf@redhat.com>  to use
> setjmp()/longjmp() instead of the more expensive swapcontext() and by
> Paolo Bonzini<pbonzini@redhat.com>  for Windows Fibers support.
>

Not a blocker at all, but why did you move the pooling to the ucontext 
implementation?  It's less expensive to create the fiber in Windows 
because there are no system calls (unlike swapcontext), but a future 
pthread-based implementation will also need the pooling.

It can be left to whoever writes the pthread stuff, though.

Paolo