From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNS3R-0001wm-Fc for qemu-devel@nongnu.org; Fri, 20 May 2011 11:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNS3Q-0002HW-I4 for qemu-devel@nongnu.org; Fri, 20 May 2011 11:55:57 -0400 Received: from thoth.sbs.de ([192.35.17.2]:22701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNS3Q-0002HR-3h for qemu-devel@nongnu.org; Fri, 20 May 2011 11:55:56 -0400 Message-ID: <4DD68F06.7030204@siemens.com> Date: Fri, 20 May 2011 17:55:50 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, qemu-devel@nongnu.org, Markus Armbruster On 2011-05-20 17:49, Peter Maydell wrote: > This patchset reverts commit f68b9d672, which was triggering > spuriously for NICs created via -device rather than -net nic. > It then reimplements the improved diagnostics with a different > approach which only applies to '-net nic'. (It's only -net nic > devices that can be ignored (ie not instantiated); -device > nic devices are always instantiated. Checking for -device user > errors like "this device wasn't plugged into any bus" is > a separate issue not addressed here.) But we still have the problem that qemu_new_nic does not call net_init_nic. That means e.g. that NICs instantiated via -device don't participate in automatic MAC assignment. Maybe fixing that makes this series obsolete. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux