From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNS5n-00033Y-Er
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:58:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNS5m-0002Rf-Mb
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:58:23 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:41456)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNS5m-0002Rb-Hx
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:58:22 -0400
Received: by pwi6 with SMTP id 6so2211918pwi.4
	for <qemu-devel@nongnu.org>; Fri, 20 May 2011 08:58:21 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DD68F9C.4050603@twiddle.net>
Date: Fri, 20 May 2011 08:58:20 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1305671572-5899-1-git-send-email-jcmvbkbc@gmail.com>
	<1305671572-5899-25-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1305671572-5899-25-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 24/26] target-xtensa: implement accurate
 window	check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

On 05/17/2011 03:32 PM, Max Filippov wrote:
> +static void gen_window_check1(DisasContext *dc, unsigned r1)
> +{
> +    if (option_enabled(dc, XTENSA_OPTION_WINDOWED_REGISTER) &&
> +            r1 / 4 > dc->used_window) {
> +        TCGv_i32 pc = tcg_const_i32(dc->pc);
> +        TCGv_i32 w = tcg_const_i32(r1 / 4);
> +
> +        gen_advance_ccount(dc);
> +        gen_helper_window_check(pc, w);
> +
> +        tcg_temp_free(w);
> +        tcg_temp_free(pc);
> +    }

dc->used_window is never set to non-zero.  I assume you meant
to do that here?



r~