Re: [Qemu-devel] [PATCH v3 05/21] scsi: reference-count requests

[Paolo Bonzini <pbonzini@redhat.com>]

On 05/20/2011 05:58 PM, Christoph Hellwig wrote:
>> >    void scsi_req_free(SCSIRequest *req)
>> >    {
>> >  -    scsi_req_dequeue(req);
>> >  +    assert(req->refcount == 0);
>> >        qemu_free(req);
>> >    }
> Is there any reason to keep a free function?

It's internal for SCSIDevice implementation, kind of a "base 
implementation" for free_req

> The pattern should be
> that people just call the function to decrement the reference count,
> and that frees the structure when it hits zero. In the current model
> that would mean moving the freeing out of ->free_req into scsi_req_unref,
> but that seems pretty sensible anyway.

free_req is still needed, because it takes care of freeing the bounce 
buffers or any other allocated data.

Paolo