From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNUW5-0006SC-QT
	for qemu-devel@nongnu.org; Fri, 20 May 2011 14:33:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNUW5-0002e4-0u
	for qemu-devel@nongnu.org; Fri, 20 May 2011 14:33:41 -0400
Received: from mail-px0-f173.google.com ([209.85.212.173]:33386)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QNUW4-0002dt-QX
	for qemu-devel@nongnu.org; Fri, 20 May 2011 14:33:40 -0400
Received: by pxi16 with SMTP id 16so2663831pxi.4
	for <qemu-devel@nongnu.org>; Fri, 20 May 2011 11:33:39 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DD6B401.2070402@twiddle.net>
Date: Fri, 20 May 2011 11:33:37 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1305889001.git.batuzovk@ispras.ru>	<a670c554431caa5966f7e648d545cd8b4cde9b0d.1305889001.git.batuzovk@ispras.ru>
	<4DD6AEF4.2040502@twiddle.net>
In-Reply-To: <4DD6AEF4.2040502@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] Add TCG optimizations stub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kirill Batuzov <batuzovk@ispras.ru>
Cc: mj.mccormack@samsung.com, qemu-devel@nongnu.org, zhur@ispras.ru

On 05/20/2011 11:12 AM, Richard Henderson wrote:
> On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
>> +            i = (op == INDEX_op_call) ?
>> +                (args[0] >> 16) + (args[0] & 0xffff) + 3 :
>> +                def->nb_args;
>> +            while (i) {
>> +                *gen_args = *args;
>> +                args++;
>> +                gen_args++;
>> +                i--;
>> +            }
> 
> If you use the correct NOP, i.e. nop vs nop[123n], then 
> I don't believe you need to compact the arguments like this.

Bah, nevermind.  I forgot that we'd have to do something else
odd to replace n-operand operation opcodes with 2-operand movi.

I went back and saw Aurelien did this with a memmove in his
patch; it's probably more efficient to move pieces at a time
to fill in holes, as you do here.


r~