From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNVdK-0007ya-L4 for qemu-devel@nongnu.org; Fri, 20 May 2011 15:45:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNVdJ-00043l-L4 for qemu-devel@nongnu.org; Fri, 20 May 2011 15:45:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNVdJ-00043Z-Do for qemu-devel@nongnu.org; Fri, 20 May 2011 15:45:13 -0400 Message-ID: <4DD6C4C5.7060909@redhat.com> Date: Fri, 20 May 2011 21:45:09 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1305812821-6805-1-git-send-email-pbonzini@redhat.com> <1305812821-6805-3-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 05/20/2011 09:38 PM, Blue Swirl wrote: > On Thu, May 19, 2011 at 4:47 PM, Paolo Bonzini wrote: > > Most definitions in softfloat.h are really target-independent. Split > > the few that stand out as target-dependent, to allow including > > softfloat.h from files that are not compiled per-target. > > Maybe the next step should be (or in place of this patch) to move the > various defines to target-xyz/cpu.h? Not sure... Adding (or increasing, I haven't checked) the dependency of softfloat on */cpu.h is bad, but a new file target-xyz/softfloat-target.h would be feasible. You'd miss the classification in the two big groups (sNAN sign bit = 0/1), but that's not a big deal. Regarding "in place of this patch" however I disagree, since this patch is a naive split of a file in two big pieces, while your proposal requires more thought. Paolo