From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QO2iQ-0007j7-1S
	for qemu-devel@nongnu.org; Sun, 22 May 2011 03:04:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QO2iP-0007Ot-9y
	for qemu-devel@nongnu.org; Sun, 22 May 2011 03:04:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8340)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QO2iO-0007Op-VR
	for qemu-devel@nongnu.org; Sun, 22 May 2011 03:04:41 -0400
Message-ID: <4DD8B584.3090600@redhat.com>
Date: Sun, 22 May 2011 10:04:36 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1305814352-15044-1-git-send-email-avi@redhat.com>
	<1305814352-15044-2-git-send-email-avi@redhat.com>
	<BANLkTikAf+-NPnsQywsmh+8Xg7uT5-4g+A@mail.gmail.com>
In-Reply-To: <BANLkTikAf+-NPnsQywsmh+8Xg7uT5-4g+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory
 region API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 05/20/2011 08:59 PM, Blue Swirl wrote:
> On Thu, May 19, 2011 at 5:12 PM, Avi Kivity<avi@redhat.com>  wrote:
> >  The memory API separates the attributes of a memory region (its size, how
> >  reads or writes are handled, dirty logging, and coalescing) from where it
> >  is mapped and whether it is enabled.  This allows a device to configure
> >  a memory region once, then hand it off to its parent bus to map it according
> >  to the bus configuration.
> >
> >  Hierarchical registration also allows a device to compose a region out of
> >  a number of sub-regions with different properties; for example some may be
> >  RAM while others may be MMIO.
> >
> >  +/* Destroy a memory region.  The memory becomes inaccessible. */
> >  +void memory_region_destroy(MemoryRegion *mr);
>
> Doesn't the lower priority region become accessible instead in some cases?

If we require that _add_subregion() and _del_subregion() be paired, then no.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.