[Qemu-devel] [PATCH 7/9] exec.h: fix coding style of the area to be moved

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [Qemu-devel] [PATCH 7/9] exec.h: fix coding style of the area to be moved
@ 2011-05-22 11:18 Blue Swirl
  2011-05-22 11:30 ` Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Blue Swirl @ 2011-05-22 11:18 UTC (permalink / raw)
  To: qemu-devel

[-- Attachment #1: Type: text/plain, Size: 3597 bytes --]

Before the next patch, fix coding style of the areas affected.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 target-alpha/exec.h      |    2 +-
 target-arm/exec.h        |    4 ++--
 target-cris/exec.h       |    2 +-
 target-m68k/exec.h       |    2 +-
 target-microblaze/exec.h |    2 +-
 target-ppc/exec.h        |    2 +-
 target-sh4/exec.h        |    2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/target-alpha/exec.h b/target-alpha/exec.h
index 6ae96d1..26c3a3a 100644
--- a/target-alpha/exec.h
+++ b/target-alpha/exec.h
@@ -39,7 +39,7 @@ register struct CPUAlphaState *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & CPU_INTERRUPT_HARD);
+    return env->interrupt_request & CPU_INTERRUPT_HARD;
 }

 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-arm/exec.h b/target-arm/exec.h
index 44e1b55..ef497d8 100644
--- a/target-arm/exec.h
+++ b/target-arm/exec.h
@@ -28,8 +28,8 @@ register struct CPUARMState *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request &
-            (CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB));
+    return env->interrupt_request &
+        (CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB);
 }

 #if !defined(CONFIG_USER_ONLY)
diff --git a/target-cris/exec.h b/target-cris/exec.h
index 2d5d297..491f17c 100644
--- a/target-cris/exec.h
+++ b/target-cris/exec.h
@@ -30,7 +30,7 @@ register struct CPUCRISState *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI));
+    return env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI);
 }

 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-m68k/exec.h b/target-m68k/exec.h
index 91daa6b..f63e849 100644
--- a/target-m68k/exec.h
+++ b/target-m68k/exec.h
@@ -30,7 +30,7 @@ register struct CPUM68KState *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & (CPU_INTERRUPT_HARD));
+    return env->interrupt_request & (CPU_INTERRUPT_HARD);
 }

 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-microblaze/exec.h b/target-microblaze/exec.h
index 1efff30..af102d6 100644
--- a/target-microblaze/exec.h
+++ b/target-microblaze/exec.h
@@ -29,7 +29,7 @@ register struct CPUMBState *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI));
+    return env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI);
 }

 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-ppc/exec.h b/target-ppc/exec.h
index f87847a..fbc0a06 100644
--- a/target-ppc/exec.h
+++ b/target-ppc/exec.h
@@ -34,7 +34,7 @@ register struct CPUPPCState *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (msr_ee && (env->interrupt_request & CPU_INTERRUPT_HARD));
+    return msr_ee && (env->interrupt_request & CPU_INTERRUPT_HARD);
 }


diff --git a/target-sh4/exec.h b/target-sh4/exec.h
index 9f1c1f6..e52838c 100644
--- a/target-sh4/exec.h
+++ b/target-sh4/exec.h
@@ -29,7 +29,7 @@ register struct CPUSH4State *env asm(AREG0);

 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & CPU_INTERRUPT_HARD);
+    return env->interrupt_request & CPU_INTERRUPT_HARD;
 }

 #ifndef CONFIG_USER_ONLY
-- 
1.6.2.4

[-- Attachment #2: 0007-exec.h-fix-coding-style-of-the-area-to-be-moved.patch --]
[-- Type: text/x-diff, Size: 4107 bytes --]

From 5a9a4488f189c97314ad81061499691214034493 Mon Sep 17 00:00:00 2001
Message-Id: <5a9a4488f189c97314ad81061499691214034493.1306062376.git.blauwirbel@gmail.com>
In-Reply-To: <c887cc861a8a531b636c0acae1e054a3861ad15a.1306062376.git.blauwirbel@gmail.com>
References: <c887cc861a8a531b636c0acae1e054a3861ad15a.1306062376.git.blauwirbel@gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 21 May 2011 12:16:05 +0000
Subject: [PATCH 7/9] exec.h: fix coding style of the area to be moved

Before the next patch, fix coding style of the areas affected.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 target-alpha/exec.h      |    2 +-
 target-arm/exec.h        |    4 ++--
 target-cris/exec.h       |    2 +-
 target-m68k/exec.h       |    2 +-
 target-microblaze/exec.h |    2 +-
 target-ppc/exec.h        |    2 +-
 target-sh4/exec.h        |    2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/target-alpha/exec.h b/target-alpha/exec.h
index 6ae96d1..26c3a3a 100644
--- a/target-alpha/exec.h
+++ b/target-alpha/exec.h
@@ -39,7 +39,7 @@ register struct CPUAlphaState *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & CPU_INTERRUPT_HARD);
+    return env->interrupt_request & CPU_INTERRUPT_HARD;
 }
 
 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-arm/exec.h b/target-arm/exec.h
index 44e1b55..ef497d8 100644
--- a/target-arm/exec.h
+++ b/target-arm/exec.h
@@ -28,8 +28,8 @@ register struct CPUARMState *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request &
-            (CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB));
+    return env->interrupt_request &
+        (CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB);
 }
 
 #if !defined(CONFIG_USER_ONLY)
diff --git a/target-cris/exec.h b/target-cris/exec.h
index 2d5d297..491f17c 100644
--- a/target-cris/exec.h
+++ b/target-cris/exec.h
@@ -30,7 +30,7 @@ register struct CPUCRISState *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI));
+    return env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI);
 }
 
 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-m68k/exec.h b/target-m68k/exec.h
index 91daa6b..f63e849 100644
--- a/target-m68k/exec.h
+++ b/target-m68k/exec.h
@@ -30,7 +30,7 @@ register struct CPUM68KState *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & (CPU_INTERRUPT_HARD));
+    return env->interrupt_request & (CPU_INTERRUPT_HARD);
 }
 
 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-microblaze/exec.h b/target-microblaze/exec.h
index 1efff30..af102d6 100644
--- a/target-microblaze/exec.h
+++ b/target-microblaze/exec.h
@@ -29,7 +29,7 @@ register struct CPUMBState *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI));
+    return env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI);
 }
 
 static inline void cpu_pc_from_tb(CPUState *env, TranslationBlock *tb)
diff --git a/target-ppc/exec.h b/target-ppc/exec.h
index f87847a..fbc0a06 100644
--- a/target-ppc/exec.h
+++ b/target-ppc/exec.h
@@ -34,7 +34,7 @@ register struct CPUPPCState *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (msr_ee && (env->interrupt_request & CPU_INTERRUPT_HARD));
+    return msr_ee && (env->interrupt_request & CPU_INTERRUPT_HARD);
 }
 
 
diff --git a/target-sh4/exec.h b/target-sh4/exec.h
index 9f1c1f6..e52838c 100644
--- a/target-sh4/exec.h
+++ b/target-sh4/exec.h
@@ -29,7 +29,7 @@ register struct CPUSH4State *env asm(AREG0);
 
 static inline int cpu_has_work(CPUState *env)
 {
-    return (env->interrupt_request & CPU_INTERRUPT_HARD);
+    return env->interrupt_request & CPU_INTERRUPT_HARD;
 }
 
 #ifndef CONFIG_USER_ONLY
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH 7/9] exec.h: fix coding style of the area to be moved
  2011-05-22 11:18 [Qemu-devel] [PATCH 7/9] exec.h: fix coding style of the area to be moved Blue Swirl
@ 2011-05-22 11:30 ` Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2011-05-22 11:30 UTC (permalink / raw)
  To: Blue Swirl; +Cc: qemu-devel

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On 2011-05-22 13:18, Blue Swirl wrote:
> Before the next patch, fix coding style of the areas affected.
> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  target-alpha/exec.h      |    2 +-
>  target-arm/exec.h        |    4 ++--
>  target-cris/exec.h       |    2 +-
>  target-m68k/exec.h       |    2 +-
>  target-microblaze/exec.h |    2 +-
>  target-ppc/exec.h        |    2 +-
>  target-sh4/exec.h        |    2 +-
>  7 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/target-alpha/exec.h b/target-alpha/exec.h
> index 6ae96d1..26c3a3a 100644
> --- a/target-alpha/exec.h
> +++ b/target-alpha/exec.h
> @@ -39,7 +39,7 @@ register struct CPUAlphaState *env asm(AREG0);
> 
>  static inline int cpu_has_work(CPUState *env)
>  {
> -    return (env->interrupt_request & CPU_INTERRUPT_HARD);
> +    return env->interrupt_request & CPU_INTERRUPT_HARD;

Maybe this patch or the series is a good change to make cpu_has_work
return a bool?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-22 11:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-22 11:18 [Qemu-devel] [PATCH 7/9] exec.h: fix coding style of the area to be moved Blue Swirl
2011-05-22 11:30 ` Jan Kiszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).