From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47396)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QO7S1-0003aw-Bv
	for qemu-devel@nongnu.org; Sun, 22 May 2011 08:08:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QO7S0-0003lz-9F
	for qemu-devel@nongnu.org; Sun, 22 May 2011 08:08:05 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:61642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QO7Rz-0003lf-Qy
	for qemu-devel@nongnu.org; Sun, 22 May 2011 08:08:04 -0400
Message-ID: <4DD8FC9D.3090200@mail.berlios.de>
Date: Sun, 22 May 2011 14:07:57 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1304799357-19281-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1304799357-19281-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Christian Brunner <chb@muc.de>

Am 07.05.2011 22:15, schrieb Stefan Weil:
> cppcheck report:
> rbd.c:246: style: Variable 'snap' is assigned a value that is never used
>
> Remove snap and the related code.
>
> Cc: Christian Brunner<chb@muc.de>
> Cc: Kevin Wolf<kwolf@redhat.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
>   block/rbd.c |    4 ----
>   1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 249a590..5c7d44e 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -524,7 +524,6 @@ static int rbd_open(BlockDriverState *bs, const char *filename, int flags)
>       RbdHeader1 *header;
>       char pool[RBD_MAX_SEG_NAME_SIZE];
>       char snap_buf[RBD_MAX_SEG_NAME_SIZE];
> -    char *snap = NULL;
>       char *hbuf = NULL;
>       int r;
>
> @@ -533,9 +532,6 @@ static int rbd_open(BlockDriverState *bs, const char *filename, int flags)
>                         s->name, sizeof(s->name))<  0) {
>           return -EINVAL;
>       }
> -    if (snap_buf[0] != '\0') {
> -        snap = snap_buf;
> -    }
>
>       if ((r = rados_initialize(0, NULL))<  0) {
>           error_report("error initializing");
>    

What about this patch? Can it be applied to the block branch?

Regards,
Stefan W.