From: Jan Kiszka <jan.kiszka@siemens.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset
Date: Mon, 23 May 2011 11:33:19 +0200 [thread overview]
Message-ID: <4DDA29DF.4030508@siemens.com> (raw)
In-Reply-To: <m3boytg62s.fsf@blackfin.pond.sub.org>
On 2011-05-23 10:43, Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@siemens.com> writes:
>
>> Drop the open-coded MAC assignment from net_init_nic and replace it with
>> standard qemu_macaddr_default_if_unset which is also used by qdev. That
>> avoid creating colliding MACs when instantiating NICs via different
>> mechanisms.
>
> Should we explicitly mention that this may change default MAC addresses?
Only if mixing old (-net) and new (-device) mechanisms.
>
>> This change requires to store the MAC as MACAddr in NICInfo, and the
>> remaining nd_table users need to be updated.
>>
>> Based on suggestion by Peter Maydell.
>
> Patch looks fine to me.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2011-05-23 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 16:46 [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset Jan Kiszka
2011-05-23 8:43 ` Markus Armbruster
2011-05-23 9:33 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA29DF.4030508@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).