From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QORVr-0007uX-Dm
	for qemu-devel@nongnu.org; Mon, 23 May 2011 05:33:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QORVq-0005xr-H7
	for qemu-devel@nongnu.org; Mon, 23 May 2011 05:33:23 -0400
Received: from david.siemens.de ([192.35.17.14]:15788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QORVq-0005xk-6J
	for qemu-devel@nongnu.org; Mon, 23 May 2011 05:33:22 -0400
Message-ID: <4DDA29DF.4030508@siemens.com>
Date: Mon, 23 May 2011 11:33:19 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4DD69AFC.7060100@siemens.com>
	<m3boytg62s.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3boytg62s.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Consistently use
	qemu_macaddr_default_if_unset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>

On 2011-05-23 10:43, Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@siemens.com> writes:
> 
>> Drop the open-coded MAC assignment from net_init_nic and replace it with
>> standard qemu_macaddr_default_if_unset which is also used by qdev. That
>> avoid creating colliding MACs when instantiating NICs via different
>> mechanisms.
> 
> Should we explicitly mention that this may change default MAC addresses?

Only if mixing old (-net) and new (-device) mechanisms.

> 
>> This change requires to store the MAC as MACAddr in NICInfo, and the
>> remaining nd_table users need to be updated.
>>
>> Based on suggestion by Peter Maydell.
> 
> Patch looks fine to me.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux