From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000
Date: Mon, 23 May 2011 08:33:03 -0500 [thread overview]
Message-ID: <4DDA620F.1090308@codemonkey.ws> (raw)
In-Reply-To: <20110523130411.GR24143@redhat.com>
On 05/23/2011 08:04 AM, Daniel P. Berrange wrote:
> On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote:
>> On 05/20/2011 01:03 PM, Richard W.M. Jones wrote:
>>>
>>> There seem to be a few unsafe uses of strto* functions. This patch
>>> just fixes the one that affects me :-)
>>
>> Sending an integer of this size is not valid JSON.
>>
>> Your patch won't accept negative numbers, correct?
>>
>> JSON only supports int64_t.
>
> That's not really true. JSON supports arbitrarily large numbers
> & integers.
Try the following snippet in your browser:
<html>
<head>
<script type="text/javascript">
alert(9223372036854775807);
</script>
</head>
</html>
The actual value of the alert will surprise you :-)
Integers in Javascript are actually represented as doubles internally
which means that integer constants are only accurate up to 52 bits.
So really, we should cap integers at 32-bit :-/
Have I mentioned recently that I really dislike JSON...
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-05-23 13:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 18:03 [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000 Richard W.M. Jones
2011-05-20 18:11 ` Anthony Liguori
2011-05-20 18:36 ` Richard W.M. Jones
2011-05-20 18:37 ` Richard W.M. Jones
2011-05-20 18:47 ` Richard W.M. Jones
2011-05-20 21:19 ` Richard W.M. Jones
2011-05-23 13:04 ` Daniel P. Berrange
2011-05-23 13:33 ` Anthony Liguori [this message]
2011-05-23 13:39 ` Richard W.M. Jones
2011-05-23 13:40 ` Daniel P. Berrange
2011-05-23 13:45 ` Anthony Liguori
2011-05-23 14:14 ` Daniel P. Berrange
2011-05-23 15:03 ` Anthony Liguori
2011-05-23 15:41 ` Daniel P. Berrange
2011-05-23 14:20 ` Markus Armbruster
2011-05-23 13:50 ` Anthony Liguori
2011-05-23 14:02 ` Luiz Capitulino
2011-05-23 14:06 ` Anthony Liguori
2011-05-23 14:24 ` Daniel P. Berrange
2011-05-23 14:29 ` Markus Armbruster
2011-05-23 14:32 ` Daniel P. Berrange
2011-05-23 15:07 ` Anthony Liguori
2011-05-23 15:19 ` Richard W.M. Jones
2011-05-23 15:24 ` Anthony Liguori
2011-05-23 15:29 ` Richard W.M. Jones
2011-05-23 15:59 ` Anthony Liguori
2011-05-23 16:06 ` Daniel P. Berrange
2011-05-23 15:38 ` Daniel P. Berrange
2011-05-23 16:18 ` Markus Armbruster
2011-05-23 16:37 ` Anthony Liguori
2011-05-24 6:26 ` Markus Armbruster
2011-05-23 23:02 ` [Qemu-devel] Use a hex string (was: [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000) Jamie Lokier
2011-05-24 2:50 ` [Qemu-devel] Use a hex string Anthony Liguori
2011-05-24 5:30 ` Jamie Lokier
2011-05-23 13:38 ` [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDA620F.1090308@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=berrange@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).