From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOVFr-0004NY-O1 for qemu-devel@nongnu.org; Mon, 23 May 2011 09:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOVFq-0004Tm-CD for qemu-devel@nongnu.org; Mon, 23 May 2011 09:33:07 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:35097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOVFq-0004TW-8e for qemu-devel@nongnu.org; Mon, 23 May 2011 09:33:06 -0400 Received: by gxk26 with SMTP id 26so2467542gxk.4 for ; Mon, 23 May 2011 06:33:05 -0700 (PDT) Message-ID: <4DDA620F.1090308@codemonkey.ws> Date: Mon, 23 May 2011 08:33:03 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20110520180331.GA21837@amd.home.annexia.org> <4DD6AEB9.6060506@codemonkey.ws> <20110523130411.GR24143@redhat.com> In-Reply-To: <20110523130411.GR24143@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, "Richard W.M. Jones" , Luiz Capitulino On 05/23/2011 08:04 AM, Daniel P. Berrange wrote: > On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: >> On 05/20/2011 01:03 PM, Richard W.M. Jones wrote: >>> >>> There seem to be a few unsafe uses of strto* functions. This patch >>> just fixes the one that affects me :-) >> >> Sending an integer of this size is not valid JSON. >> >> Your patch won't accept negative numbers, correct? >> >> JSON only supports int64_t. > > That's not really true. JSON supports arbitrarily large numbers > & integers. Try the following snippet in your browser: The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only accurate up to 52 bits. So really, we should cap integers at 32-bit :-/ Have I mentioned recently that I really dislike JSON... Regards, Anthony Liguori