qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
	qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000
Date: Mon, 23 May 2011 08:50:55 -0500	[thread overview]
Message-ID: <4DDA663F.30907@codemonkey.ws> (raw)
In-Reply-To: <20110523134021.GT24143@redhat.com>

>> The actual value of the alert will surprise you :-)
>>
>> Integers in Javascript are actually represented as doubles
>> internally which means that integer constants are only accurate up
>> to 52 bits.
>>
>> So really, we should cap integers at 32-bit :-/
>>
>> Have I mentioned recently that I really dislike JSON...
>
> NB, I am distinguishing between JSON the generic specification and
> JSON as implemented in web browsers. JSON the specification has *no*
> limitation on integers.

The spec has no notion of integers at all.  Here's the relevant text. 
Note that the BNF only has a single entry point for numbers.  It does 
not distinguish between integers and floating point numbers.  Also, the 
only discussion of valid numbers is about whether the number can be 
represented as a rational number.  I think the only way to read the spec 
here is that *all* numbers are meant to be represented as floating point 
numbers.

Regards,

Anthony Liguori

2.4.  Numbers

    The representation of numbers is similar to that used in most
    programming languages.  A number contains an integer component that
    may be prefixed with an optional minus sign, which may be followed by
    a fraction part and/or an exponent part.

    Octal and hex forms are not allowed.  Leading zeros are not allowed.

    A fraction part is a decimal point followed by one or more digits.

    An exponent part begins with the letter E in upper or lowercase,
    which may be followed by a plus or minus sign.  The E and optional
    sign are followed by one or more digits.

    Numeric values that cannot be represented as sequences of digits
    (such as Infinity and NaN) are not permitted.


          number = [ minus ] int [ frac ] [ exp ]

          decimal-point = %x2E       ; .

          digit1-9 = %x31-39         ; 1-9

          e = %x65 / %x45            ; e E

          exp = e [ minus / plus ] 1*DIGIT

          frac = decimal-point 1*DIGIT

          int = zero / ( digit1-9 *DIGIT )

          minus = %x2D               ; -

          plus = %x2B                ; +

          zero = %x30                ; 0

  parent reply	other threads:[~2011-05-23 13:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 18:03 [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000 Richard W.M. Jones
2011-05-20 18:11 ` Anthony Liguori
2011-05-20 18:36   ` Richard W.M. Jones
2011-05-20 18:37     ` Richard W.M. Jones
2011-05-20 18:47   ` Richard W.M. Jones
2011-05-20 21:19   ` Richard W.M. Jones
2011-05-23 13:04   ` Daniel P. Berrange
2011-05-23 13:33     ` Anthony Liguori
2011-05-23 13:39       ` Richard W.M. Jones
2011-05-23 13:40       ` Daniel P. Berrange
2011-05-23 13:45         ` Anthony Liguori
2011-05-23 14:14           ` Daniel P. Berrange
2011-05-23 15:03             ` Anthony Liguori
2011-05-23 15:41               ` Daniel P. Berrange
2011-05-23 14:20           ` Markus Armbruster
2011-05-23 13:50         ` Anthony Liguori [this message]
2011-05-23 14:02           ` Luiz Capitulino
2011-05-23 14:06             ` Anthony Liguori
2011-05-23 14:24           ` Daniel P. Berrange
2011-05-23 14:29           ` Markus Armbruster
2011-05-23 14:32             ` Daniel P. Berrange
2011-05-23 15:07             ` Anthony Liguori
2011-05-23 15:19               ` Richard W.M. Jones
2011-05-23 15:24                 ` Anthony Liguori
2011-05-23 15:29                   ` Richard W.M. Jones
2011-05-23 15:59                     ` Anthony Liguori
2011-05-23 16:06                       ` Daniel P. Berrange
2011-05-23 15:38                   ` Daniel P. Berrange
2011-05-23 16:18                   ` Markus Armbruster
2011-05-23 16:37                     ` Anthony Liguori
2011-05-24  6:26                       ` Markus Armbruster
2011-05-23 23:02                 ` [Qemu-devel] Use a hex string (was: [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000) Jamie Lokier
2011-05-24  2:50                   ` [Qemu-devel] Use a hex string Anthony Liguori
2011-05-24  5:30                     ` Jamie Lokier
2011-05-23 13:38     ` [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDA663F.30907@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=berrange@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).