From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOYyU-0002dI-UD for qemu-devel@nongnu.org; Mon, 23 May 2011 13:31:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOYyU-0001T6-0p for qemu-devel@nongnu.org; Mon, 23 May 2011 13:31:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOYyT-0001T2-Pu for qemu-devel@nongnu.org; Mon, 23 May 2011 13:31:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4NHVPnW006665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 May 2011 13:31:25 -0400 Message-ID: <4DDA99F1.50907@redhat.com> Date: Mon, 23 May 2011 19:31:29 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1306143819-30287-1-git-send-email-kraxel@redhat.com> <1306143819-30287-18-git-send-email-kraxel@redhat.com> <4DDA6966.7050307@redhat.com> <4DDA7073.2060702@redhat.com> <4DDA74E2.4030401@redhat.com> In-Reply-To: <4DDA74E2.4030401@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/18] usb: move cancel callback to USBDeviceInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Hi, On 05/23/2011 04:53 PM, Gerd Hoffmann wrote: > Hi, > >> Good spotting, this is indeed a issue which needs fixing. It isn't >> introduced by this patch though, it exists even without the usb patch >> queue. > > Something like the attached patch should fix it. The diff looks incomplete (missing changes to usbbus.c), but I see you send a more complete patch in a separate mail, I'll take a look at that one instead. Regards, Hans