qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h
Date: Tue, 24 May 2011 08:37:04 +0200	[thread overview]
Message-ID: <4DDB5210.5010302@redhat.com> (raw)
In-Reply-To: <20110523211121.GB15554@hall.aurel32.net>

On 05/23/2011 11:11 PM, Aurelien Jarno wrote:
> Looks ok in principle, but I wonder if we should really create a new
> header for that. softfloat-specialize.h is already supposed to contain
> the target specific functions, so it's probably a good idea to move them
> there instead.

I was wondering about that too... I was thinking of separating _private_ 
target-specific functions and a public interface that is target-specific 
just because we go for macros rather than extern variables.

In fact, using const variables is another way to solve the problem, 
without introducing a new header.  I'll probably do that for v2.

> Also please note that this will conflict with the patch series I sent
> recently about removing softfloat-native (most of the patches have been
> acked, I'll send a new series soon).

Yes, no problem.

Paolo

  reply	other threads:[~2011-05-24  6:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 13:46 [Qemu-devel] [PATCH 0/3] make endian-independent unaligned memory access functions available in libhw Paolo Bonzini
2011-05-19 13:46 ` [Qemu-devel] [PATCH 1/3] move WORDS_ALIGNED to qemu-common.h Paolo Bonzini
2011-05-19 13:47 ` [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h Paolo Bonzini
2011-05-20 19:38   ` Blue Swirl
2011-05-20 19:45     ` Paolo Bonzini
2011-05-20 19:54       ` Blue Swirl
2011-05-23 21:11   ` Aurelien Jarno
2011-05-24  6:37     ` Paolo Bonzini [this message]
2011-05-19 13:47 ` [Qemu-devel] [PATCH 3/3] move unaligned memory access functions to bswap.h Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDB5210.5010302@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).