From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43527)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QOlEw-0006fh-Jx
	for qemu-devel@nongnu.org; Tue, 24 May 2011 02:37:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QOlEv-0007nT-Qt
	for qemu-devel@nongnu.org; Tue, 24 May 2011 02:37:14 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:60258)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QOlEv-0007nO-Ir
	for qemu-devel@nongnu.org; Tue, 24 May 2011 02:37:13 -0400
Received: by pzk30 with SMTP id 30so3486437pzk.4
	for <qemu-devel@nongnu.org>; Mon, 23 May 2011 23:37:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4DDB5210.5010302@redhat.com>
Date: Tue, 24 May 2011 08:37:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1305812821-6805-1-git-send-email-pbonzini@redhat.com>	<1305812821-6805-3-git-send-email-pbonzini@redhat.com>
	<20110523211121.GB15554@hall.aurel32.net>
In-Reply-To: <20110523211121.GB15554@hall.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 05/23/2011 11:11 PM, Aurelien Jarno wrote:
> Looks ok in principle, but I wonder if we should really create a new
> header for that. softfloat-specialize.h is already supposed to contain
> the target specific functions, so it's probably a good idea to move them
> there instead.

I was wondering about that too... I was thinking of separating _private_ 
target-specific functions and a public interface that is target-specific 
just because we go for macros rather than extern variables.

In fact, using const variables is another way to solve the problem, 
without introducing a new header.  I'll probably do that for v2.

> Also please note that this will conflict with the patch series I sent
> recently about removing softfloat-native (most of the patches have been
> acked, I'll send a new series soon).

Yes, no problem.

Paolo