qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: david@gibson.dropbear.id.au, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device
Date: Tue, 24 May 2011 15:08:47 +0200	[thread overview]
Message-ID: <4DDBADDF.5030904@redhat.com> (raw)
In-Reply-To: <m3hb8kmerm.fsf@blackfin.pond.sub.org>

On 05/24/2011 03:03 PM, Markus Armbruster wrote:
> >  This is particularly important with the conversion from scsi-disk
> >  to scsi-{cd,hd} that Markus made.  After his patches, if you
> >  specify a scsi-cd device attached to an if=none drive, the default
> >  VSCSI controller will not be created and, without qdevification,
> >  you will not be able to add yours.
>
> Really?  Hasn't that always been the case?

What hasn't always been the case? :)

1) "the default VSCSI controller will not be created" -- no, this is new 
with scsi-cd: scsi-disk never was on the default_driver_table in vl.c, 
as you said in the commit message for af6bf13 (defaults: ide-cd, ide-hd 
and scsi-cd devices suppress default CD-ROM, 2011-05-18).  In fact, I 
believe you could add scsi-hd there too.

2) "without qdevification, you will not be able to add yours" -- that of 
course has always been the case.  But I never noticed because there was 
no way to avoid creating the default CD-ROM, and this in turn forced the 
non-qdev-clean creation of the VSCSI controller.

Paolo

  reply	other threads:[~2011-05-24 13:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 11:45 [Qemu-devel] [PATCH 0/3] spapr qdevification Paolo Bonzini
2011-05-24 11:45 ` [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device Paolo Bonzini
2011-05-24 13:03   ` Markus Armbruster
2011-05-24 13:08     ` Paolo Bonzini [this message]
2011-05-24 13:34       ` Markus Armbruster
2011-05-24 22:12   ` David Gibson
2011-05-25  7:29     ` Paolo Bonzini
2011-05-30  3:16       ` David Gibson
2011-05-24 11:45 ` [Qemu-devel] [PATCH 2/3] spapr: prepare for qdevification of irq Paolo Bonzini
2011-05-24 11:45 ` [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev Paolo Bonzini
2011-05-24 22:14   ` David Gibson
2011-05-25  7:30     ` Paolo Bonzini
2011-05-30  3:16       ` David Gibson
2011-05-25 15:13     ` Markus Armbruster
2011-05-30  3:17       ` David Gibson
2011-05-24 13:04 ` [Qemu-devel] [PATCH 0/3] spapr qdevification Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDBADDF.5030904@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).