From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOt5T-0004Ma-Vk for qemu-devel@nongnu.org; Tue, 24 May 2011 11:00:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOt5T-0001Ni-1d for qemu-devel@nongnu.org; Tue, 24 May 2011 10:59:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOt5S-0001Nb-Pi for qemu-devel@nongnu.org; Tue, 24 May 2011 10:59:58 -0400 Message-ID: <4DDBC895.7050907@redhat.com> Date: Tue, 24 May 2011 17:02:45 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <20110517160406.GA28196@lst.de> In-Reply-To: <20110517160406.GA28196@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: clarify the meaning of BDRV_O_NOCACHE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 17.05.2011 18:04, schrieb Christoph Hellwig: > Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache, > but no writeback semantics. All existing callers are changed to also > specify BDRV_O_CACHE_WB to give them writeback semantics. > > Signed-off-by: Christoph Hellwig Thanks, applied to the block branch. Changing bdrv_pwrite_sync wouldn't hurt, but it's harmless, so we can do it on top. Kevin