From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
patches@linaro.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets
Date: Wed, 25 May 2011 22:05:08 +0200 [thread overview]
Message-ID: <4DDD60F4.3050207@redhat.com> (raw)
In-Reply-To: <4DDD4132.1080708@mail.berlios.de>
On 05/25/2011 07:49 PM, Stefan Weil wrote:
>
> + if [ -e "$source_path/$f" -a ! -e "$f" ]; then
> + symlink "$source_path/$f" "$f"
> + fi
Please use && instead of -a, and "! [" instead of "[ !".
Paolo
prev parent reply other threads:[~2011-05-25 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 17:30 [Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets Peter Maydell
2011-05-25 17:49 ` Stefan Weil
2011-05-25 20:05 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD60F4.3050207@redhat.com \
--to=pbonzini@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).