From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QPKKP-00075A-W9
	for qemu-devel@nongnu.org; Wed, 25 May 2011 16:05:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QPKKP-0003qi-CI
	for qemu-devel@nongnu.org; Wed, 25 May 2011 16:05:13 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4DDD60F4.3050207@redhat.com>
Date: Wed, 25 May 2011 22:05:08 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1306344617-1645-1-git-send-email-peter.maydell@linaro.org>
	<4DDD4132.1080708@mail.berlios.de>
In-Reply-To: <4DDD4132.1080708@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] configure: Don't create symlinks to
	nonexistent targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, patches@linaro.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>

On 05/25/2011 07:49 PM, Stefan Weil wrote:
>
> + if [ -e "$source_path/$f" -a ! -e "$f" ]; then
> + symlink "$source_path/$f" "$f"
> + fi

Please use && instead of -a, and "! [" instead of "[ !".

Paolo