From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPeoV-0003V3-KZ for qemu-devel@nongnu.org; Thu, 26 May 2011 13:57:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPeoU-0006yE-QS for qemu-devel@nongnu.org; Thu, 26 May 2011 13:57:39 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:59261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPeoU-0006vH-J0 for qemu-devel@nongnu.org; Thu, 26 May 2011 13:57:38 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4QHelaC021650 for ; Thu, 26 May 2011 11:40:47 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4QHv47Y159130 for ; Thu, 26 May 2011 11:57:06 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4QBv38b012782 for ; Thu, 26 May 2011 05:57:03 -0600 Message-ID: <4DDE9466.9030300@linux.vnet.ibm.com> Date: Thu, 26 May 2011 13:56:54 -0400 From: Stefan Berger MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] Buildfix: fix libcacard build with -m32 on 64bit machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori When configuring with --extra-cflags="-m32" on a 64bit machine the following error appears during compilation: make -C libhw64 V="1" TARGET_DIR="libhw64/" all make[1]: Entering directory `/root/tmp/qemu-git/libhw64' make[1]: Leaving directory `/root/tmp/qemu-git/libhw64' make -C libcacard V="1" TARGET_DIR="libcacard/" all make[1]: Entering directory `/root/tmp/qemu-git/libcacard' gcc -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lrt -o vscclient cac.o event.o vcard.o vreader.o vcard_emul_nss.o vcard_emul_type.o card_7816.o ../osdep.o ../oslib-posix.o ../qemu-thread-posix.o ../trace.o ../qemu-malloc.o ../qemu-timer-common.o vscclient.o cac.o: could not read symbols: File in wrong format collect2: ld returned 1 exit status make[1]: *** [vscclient] Error 1 make[1]: Leaving directory `/root/tmp/qemu-git/libcacard' make: *** [subdir-libcacard] Error 2 The LDFLAGS are not passed to the compiled. The below patch fixes it. Signed-off-by: Stefan Berger --- libcacard/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu-git/libcacard/Makefile =================================================================== --- qemu-git.orig/libcacard/Makefile +++ qemu-git/libcacard/Makefile @@ -9,7 +9,7 @@ QEMU_OBJS=$(addprefix ../, $(oslib-obj-y QEMU_CFLAGS+=-I../ vscclient: $(libcacard-y) $(QEMU_OBJS) vscclient.o - $(call quiet-command,$(CC) $(libcacard_libs) -lrt -o $@ $^," LINK $(TARGET_DIR)$@") + $(call quiet-command,$(CC) $(LDFLAGS) $(libcacard_libs) -lrt -o $@ $^," LINK $(TARGET_DIR)$@") all: vscclient