From: Stefan Weil <weil@mail.berlios.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
patches@linaro.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug
Date: Thu, 26 May 2011 20:28:50 +0200 [thread overview]
Message-ID: <4DDE9BE2.3010600@mail.berlios.de> (raw)
In-Reply-To: <1306433153-3671-1-git-send-email-peter.maydell@linaro.org>
Am 26.05.2011 20:05, schrieb Peter Maydell:
> The PPC helper functions booke206_tlbflush and booke_setpid both
> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
> to avoid a compilation failure when compiling in debug mode.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target-ppc/translate_init.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
See http://patchwork.ozlabs.org/patch/96665/
It's a waste of time if build fixes take more than 3 days to get committed.
The typical process - several days until the maintainer accepts it, more
days until there is a pull request, even more days until it is pulled -
is good enough for new features, but too slow for bug fixes, especially
when they fix broken builds.
Cheers,
Stefan W.
next prev parent reply other threads:[~2011-05-26 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 18:05 [Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug Peter Maydell
2011-05-26 18:28 ` Stefan Weil [this message]
2011-05-26 18:31 ` Peter Maydell
2011-05-26 21:32 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE9BE2.3010600@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).