From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPfJ6-00005F-LJ for qemu-devel@nongnu.org; Thu, 26 May 2011 14:29:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPfJ5-0003Qc-FM for qemu-devel@nongnu.org; Thu, 26 May 2011 14:29:16 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:51747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPfJ5-0003QV-3c for qemu-devel@nongnu.org; Thu, 26 May 2011 14:29:15 -0400 Message-ID: <4DDE9BE2.3010600@mail.berlios.de> Date: Thu, 26 May 2011 20:28:50 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1306433153-3671-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1306433153-3671-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , patches@linaro.org, qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Paul Brook Am 26.05.2011 20:05, schrieb Peter Maydell: > The PPC helper functions booke206_tlbflush and booke_setpid both > take an i32 argument, so we need to use TCGv_i32 rather than TCGv, > to avoid a compilation failure when compiling in debug mode. > > Signed-off-by: Peter Maydell > --- > target-ppc/translate_init.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > See http://patchwork.ozlabs.org/patch/96665/ It's a waste of time if build fixes take more than 3 days to get committed. The typical process - several days until the maintainer accepts it, more days until there is a pull request, even more days until it is pulled - is good enough for new features, but too slow for bug fixes, especially when they fix broken builds. Cheers, Stefan W.